Repository navigation
Quote the database name when dropping it in docker_run.sh - #498
Open
jfarin-gda wants to merge 1 commit into
Open
jfarin-gda wants to merge 1 commit into
jfarin-gda wants to merge 1 commit into
Conversation
|
Hello @jfarin-gda! This is your first pull request on docker repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS_ERASE_DB=1,docker_run.shrunsdrop database if exists $DB_NAME;without quoting the name. A name with a hyphen (my-shop) causes SQL error 1064, andset -estops the script before the install. The name is now quoted with backticks. The same line is updated in the generated copies underbase/images/.PS_INSTALL_AUTO=1,PS_ERASE_DB=1,PS_INSTALL_DB=1andDB_NAME=my-shop. Before: SQL error 1064. After: the install succeeds. Names without a hyphen work as before.Tested on images 9, 8.2.7 and 1.7.8, against MariaDB 11.4 and MySQL 5.7 and 8.0 (the fix applied to the script inside the published images, images not rebuilt).
Note: #451 also touches this line by removing the
DROP. If it is merged first, this PR can be closed.