Skip to content

DistributedWeightedRandomSampler remove shuffle=False option #6885

Closed
#6886
Closed
DistributedWeightedRandomSampler remove shuffle=False option#6885
#6886
Assignees
AmirAflak
Labels
Contribution wantedFeature requestgood first issueGood for newcomers

Description

@wyli
wyli
opened on Aug 17, 2023

Describe the bug

MONAI/monai/data/samplers.py

Line 98 in 4cd717c

shuffle: bool = True,

the random sampler will always generate 'shuffled' outputs, the shuffle=False option is not valid and should be removed

Activity

  1. wyli
    added
    good first issueGood for newcomers
    Contribution wanted
    Feature request
    on Aug 17, 2023

  2. AmirAflak commented on Aug 17, 2023

    @AmirAflak
    AmirAflak
    on Aug 17, 2023
    Contributor

    Would like to take this.

  3. wyli
    assigned
    AmirAflak
    on Aug 17, 2023
  4. wyli
    closed this as completedin #6886on Aug 18, 2023
  5. wyli
    added a commit that references this issue on Aug 18, 2023

    remove: shuffle=False option (#6886)

    6e47140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Contribution wantedFeature requestgood first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions