Repository navigation
5821 Add interface for bundle workflows - #5822
Merged
Merged
Conversation
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Merge branch 'Project-MONAI:main' into main
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
marked this pull request as ready for review
March 10, 2023 15:37
Contributor
Author
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/build |
ericspod
approved these changes
Mar 13, 2023
ericspod
left a comment
Member
There was a problem hiding this comment.
I'm good with this now, thanks!
wyli
reviewed
Mar 13, 2023
wyli
left a comment
Contributor
There was a problem hiding this comment.
thanks, I have some minor comments
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
wyli
reviewed
Mar 15, 2023
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5821 .
Description
The main idea of this PR is to solve 3 pain points of the current bundle training or inference workflow:
trainingorevaluationlist, so 3rd party package can't flexibly initialize and run the workflows separately, see: Defineinitialize,run,finalizesections in bundle config model-zoo#294. This PR splits it intoinitialize,runandfinalize, and still compatible with current existing bundles.ConfigParser, but some developers of bundles don't want to write JSON or YAML configs. This PR implemented the interface to support both config-based and python-based workflows.TrainPropertiesandinferencePropertiesinterfaces and check tool.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.