Repository navigation
Replace deprecated arg in torchvision models - #6401
Merged
Merged
Conversation
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Nic-Ma
approved these changes
Apr 19, 2023
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Please ensure it's compatible with PyTorch 1.7 - 2.0.
Thanks.
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For torchvision models, the parameter
pretrainedis deprecated since 0.13 and may be removed in the future. OurTorchVisionFCmodel has been using this parameter. This PR updatedTorchVisionFCto remove calling pretrained and instead to callweightswith appropriate defaults without any change in the functionality (backward compatible).Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.