Repository navigation
Added (Rand)ScaleScaleIntensityFixedMean(d) and modified (Rand)AdjustContrast(d) - #6542
Merged
Merged
Conversation
…Contrast(d) with by adding arguments
for more information, see https://pre-commit.ci
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
aaronkujawa
marked this pull request as ready for review
May 24, 2023 07:47
Contributor
|
/build |
ericspod
reviewed
May 24, 2023
ericspod
reviewed
May 24, 2023
Contributor
|
Hi @KumoLiu , Could you please help review this PR? Thanks in advance. |
KumoLiu
reviewed
May 25, 2023
KumoLiu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, few comments inline.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
ericspod
reviewed
May 30, 2023
Signed-off-by: Aaron Kujawa <askujawa@gmail.com>
wyli
approved these changes
Jun 2, 2023
wyli
left a comment
Contributor
There was a problem hiding this comment.
Many thanks @aaronkujawa, I'm merging this after tagging v1.2.
Contributor
Author
Contributor
|
/build |
wyli
enabled auto-merge (squash)
June 8, 2023 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the intensity transform ScaleIntensityFixedMean (including its random and random dictionary version) and modifies the intensity transform AdjustContrast and its dictionary version. It adds functionality available in the corresponding nnU-Net transforms ContrastAugmentationTransform and GammaTransform.
Specifically, ScaleIntensityFixedMean scales the intensity of the input image by a factor v = v * (1 + factor) (same as the existing ScaleIntensity transform when used with the factor argument). The added functionality is provided by two arguments:
fixed_mean: subtract the mean intensity before scaling with factor, then add the same value after scaling to ensure that the output has the same mean intensity as the input.
preserve_range: clips the output array/tensor to the range of the input array/tensor
AdjustContrast was modified by adding two arguments:
invert_image: multiplies all intensity values by -1 before gamma transform and again after gamma transform
retain_stats: applies a scaling factor and an offset to all intensity values after the gamma transform to ensure that the output intensity distribution has the same mean and standard deviation as the intensity distribution of the input
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.