Skip to content

Add download_large_files in monai/bundle/scripts.py - #6958

Merged
wyli merged 5 commits into
Project-MONAI:devfrom
KumoLiu:download-large-files
Sep 7, 2023
Merged

wyli merged 5 commits into
Project-MONAI:devfrom
KumoLiu:download-large-files

Conversation

@KumoLiu

@KumoLiu KumoLiu commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Fixes #6362 .

Description

Add download_large_files in monai/bundle/scripts.py.
Refer to the one in https://github.com/Project-MONAI/model-zoo/blob/131b0da3f540ed13a8a1c02d8395e92a682d47cf/ci/utils.py#L93.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
KumoLiu requested review from Nic-Ma, ericspod and wyli September 7, 2023 08:34
Comment thread monai/bundle/scripts.py Outdated
Comment thread monai/bundle/scripts.py Outdated

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

Signed-off-by: KumoLiu <yunl@nvidia.com>
@wyli

wyli commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) September 7, 2023 11:50
@wyli
wyli merged commit ef7debe into Project-MONAI:dev Sep 7, 2023
@KumoLiu
KumoLiu deleted the download-large-files branch September 8, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle Download Large Files

2 participants