Repository navigation
Improve ckpt_export - #6965
Merged
Merged
Improve ckpt_export #6965
ckpt_export #6965Conversation
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
KumoLiu
marked this pull request as ready for review
September 11, 2023 10:13
for more information, see https://pre-commit.ci
KumoLiu
commented
Sep 11, 2023
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
reviewed
Sep 11, 2023
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
approved these changes
Sep 11, 2023
wyli
left a comment
Contributor
There was a problem hiding this comment.
Thanks, it looks good to me.
Contributor
|
/build |
wyli
enabled auto-merge (squash)
September 11, 2023 12:16
binliunls
approved these changes
Sep 11, 2023
ericspod
reviewed
Sep 11, 2023
ericspod
reviewed
Sep 11, 2023
ericspod
approved these changes
Sep 11, 2023
ericspod
left a comment
Member
There was a problem hiding this comment.
Looks good, I had a few minor changes for error messages but otherwise this looks like a good solution.
wyli
disabled auto-merge
September 11, 2023 13:18
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6953
Description
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.