Skip to content

Support return dice for each class in DiceMetric - #7163

Merged
wyli merged 3 commits into
Project-MONAI:devfrom
KumoLiu:meandice
Oct 25, 2023
Merged

wyli merged 3 commits into
Project-MONAI:devfrom
KumoLiu:meandice

Conversation

@KumoLiu

@KumoLiu KumoLiu commented Oct 25, 2023 •

Copy link
Copy Markdown
Contributor

Fixes #7162
Fixes #7164

Description

Add return_with_label, if True or a list, will return the metrics with the corresponding label name, only works when reduction="mean_batch".
https://github.com/pytorch/ignite/blob/47b95d087a0f8713a9d24bcfe3a539b08101ba7a/ignite/metrics/metric.py#L424

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
KumoLiu marked this pull request as ready for review October 25, 2023 10:10
@KumoLiu
KumoLiu requested review from Nic-Ma, ericspod and wyli October 25, 2023 10:10
Comment thread monai/metrics/meandice.py Outdated
Signed-off-by: KumoLiu <yunl@nvidia.com>

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli

wyli commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) October 25, 2023 20:59
@wyli
wyli merged commit 85243f5 into Project-MONAI:dev Oct 25, 2023
@KumoLiu
KumoLiu deleted the meandice branch October 26, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when build docs Get Dice for each class in DiceMetric

2 participants