Repository navigation
Adding a network CellSamWrapper - #7981
Conversation
Signed-off-by: am <am>
for more information, see https://pre-commit.ci Signed-off-by: am <am>
for more information, see https://pre-commit.ci
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the PR, overall looks good me, several minor comments inline.
|
Hi @myron, please help include the segment_anything in the requirements-dev.txt, then it will be installed in the ci env and test all the things. Thanks! |
Hi, I can do it, but I don't think we should do it, it's a very limited use case, and I don't think we should ask every developer to install it. |
Hi @myron, yes we need to include that, then all the test cases can be tested correctly. Users don't need to install "requirement-dev", they can choose what they want to install like |
added |
|
all done, please check |
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
/build |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
/build |
Adding a network CellSamWrapper, a thin wrapper around SAM, which can be used for 2D segmentation tasks. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: am <am> Signed-off-by: myron <amyronenko@nvidia.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: am <am> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Adding a network CellSamWrapper, a thin wrapper around SAM, which can be used for 2D segmentation tasks.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.