Missing parameter declarations in 'X' prefix mos device declaration #401

Activity

1. das-dias commented on Jun 11, 2025

   

   das-dias

   on Jun 11, 2025

   Last edited by das-dias

   Author

   More actions

   I managed to fix some of the issues using the following changes:

           number_of_positionals = prefix_data.number_of_positionals_min
           if number_of_positionals and stop_location is not None: # model is optional
               additional, stop_location = self._line.read_words(stop_location, number_of_positionals)
               self._parameters.extend(additional)
           if prefix_data.multi_devices and stop_location is not None:
               remaining, stop_location = self._line.split_words(stop_location, until='=')
               self._parameters.extend(remaining)
           # Fix missing parameters in X mosfet device model declarations
           if prefix_data.has_variable_number_of_pins and stop_location is not None:
               remaining, stop_location = self._line.split_words(stop_location, until='\n\r')
               self._parameters.extend(remaining)

   This code prevents the model parameter from being overwritten, and also reads the remainder of the parameters for the device declaration with 'X' prefix.

   However when exporting the circuit, all positional parameters appear before nodes and model declaration, which is an issue.

   Edit 2)

   After further reading and debugging, I managed to solve the issue by not updating the positional parameters, but the optionals using the has_optionals flag of the PrefixData Class:

   self.has_variable_number_of_pins = prefix in ('Q', 'X') # NPinElement, Q has 3 to 4 pins
   self.has_optionals = prefix in ('Q', 'X')

   This way we can read out the parameters and correctly export the netlist back to a spice file with nodes and parameters in correct order.