Skip to content

fix: align performance metrics group visibility with pricing - #7374

Open
seefs001 wants to merge 1 commit into
QuantumNous:mainfrom
seefs001:fix/perf-summary-user-group
Open

seefs001 wants to merge 1 commit into
QuantumNous:mainfrom
seefs001:fix/perf-summary-user-group

Conversation

@seefs001

@seefs001 seefs001 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

⚠️ 提交说明 / PR Notice

English template: .github/PULL_REQUEST_TEMPLATE/en.md

Important

  • 描述可用 AI 辅助。提交前请审阅全文,并声明对其负责,避免未经核对的直接粘贴。
  • 请按本模板填写后再提交。

🔗 关联任务 / Related Issue

  • 新功能请填写下方 Issue 编号;若还没有对应 Issue,请先自行创建。功能讨论请放在 Issue 中进行。

  • 改动较大或方向性变更,请先在关联 Issue 中与维护者达成一致,再提交 PR。

  • Bug 修复请关联对应 Issue。设计取舍、理解偏差或预期不一致,更适合作为讨论或功能请求。

  • Closes 模型广场 性能页面 会泄露 隐藏的分组 #7309

🚀 变更类型 / Type of change

  • 🐛 Bug 修复 (Bug fix)
  • ✨ 新功能 (New feature)
  • ⚡ 性能优化 / 重构 (Refactor)
  • 📝 文档更新 (Documentation)

📝 变更描述 / Description

(简述做了什么、为什么生效。如果难以简述,建议先拆分范围,或在 Issue 中与维护者对齐。)

性能监控页面和价格页面可用分组对齐,默认使用用户可用分组,用户登录状态下叠加分组规则。

📸 运行证明 / Proof of Work

(请写明如何验证:实际步骤与观察结果。UI 变更请附截图或录屏;Bug 修复请说明复现过程与修复后结果。)

✅ 提交前检查项 / Checklist

  • 人工确认: 无论描述是否由 AI 生成,我已审阅全部内容,并声明对其准确性与完整性负责。
  • 非重复提交: 我已搜索现有的 IssuesPRs,确认不是重复提交。
  • 新功能关联 Issue: 若此 PR 标记为 New feature,我已关联对应 Issue;若尚无 Issue,我已先自行创建。
  • 事前沟通: 若改动较大或涉及方向性变更,已在关联 Issue 中与维护者沟通并达成一致。
  • 功能范围: 本 PR 不是 Coding Plan、逆向渠道、第三方封装接口,也不是对 Codex 渠道类型的改动。
  • 范围聚焦: 本 PR 为一项聚焦改动,未包含无关代码。
  • 本地验证: 已在本地运行并通过测试或手动验证,维护者可以据此复核。
  • 安全合规: 代码中无敏感凭据,且符合项目代码规范。

Summary by CodeRabbit

  • Bug Fixes
    • Performance metrics now display data only for groups available to the current user.
    • Improved filtering ensures inactive or inaccessible groups are excluded from metric summaries.
    • Automatic group metrics remain available where applicable.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 93a10130-7722-4254-aaeb-9a37f6c77393

📥 Commits

Reviewing files that changed from the base of the PR and between 04c6473 and 1347870.

📒 Files selected for processing (1)
  • controller/perf_metrics.go

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


Walkthrough

The controller now limits performance metric queries and returned groups to groups usable by the current user. It resolves the user group from the cache and retains active ratio groups plus "auto".

Changes

Performance group visibility

Layer / File(s) Summary
Apply usable groups to performance metrics
controller/perf_metrics.go
The controller adds getPerfMetricsUsableGroups, uses its keys for QuerySummaryAll, and filters GetPerfMetrics results with the same map. The previous filterActiveGroups helper was removed.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 13478

The updated endpoints restrict returned performance-group metrics through the user’s usable-group set, with no supported remaining visibility regression.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: aligning performance metrics group visibility with pricing rules.
Linked Issues check ✅ Passed Issue #7309 requires the model marketplace performance page to stop exposing hidden groups. The PR uses service.GetUserUsableGroups for the current user, intersects the result with active ratio grou…
Out of Scope Changes check ✅ Passed The reviewed change is limited to performance metrics group selection and filtering in controller/perf_metrics.go. The change directly supports issue #7309 and introduces no unrelated behavior.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the groups at night
Hidden paths stay out of sight
The user cache points the way
Metrics show the right display
“Auto” hops in, then rests just right
Safe numbers greet the morning light

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

模型广场 性能页面 会泄露 隐藏的分组

1 participant