feat(frontend): add fetch-from-upstream button in model mapping - #7413
Open
Bliod-Cook wants to merge 1 commit into
Open
Bliod-Cook wants to merge 1 commit into
Bliod-Cook wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe channel mapping editor now supports fetching upstream models through a dialog picker. Single-selection mode uses radios and preserves manual input. The drawer centralizes discovery controls and feedback. Tests cover discovery, permissions, cancellation, mapping updates, and unsupported channel types. ChangesUpstream model mapping
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant ChannelMutateDrawer
participant UpstreamModelPicker
participant UpstreamModelSelection
participant ModelMappingEditor
ChannelMutateDrawer->>UpstreamModelPicker: provide discovery state and fetch callback
UpstreamModelPicker->>ChannelMutateDrawer: request upstream models
ChannelMutateDrawer->>UpstreamModelPicker: return models and status
UpstreamModelPicker->>UpstreamModelSelection: display normalized models
UpstreamModelSelection->>UpstreamModelPicker: return one selected model
UpstreamModelPicker->>ModelMappingEditor: apply selected model
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new upstream-model picker handles successful discovery with the expected status, and no concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. I’m a rabbit with models to choose, Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English template:
.github/PULL_REQUEST_TEMPLATE/en.mdImportant
🔗 关联任务 / Related Issue
新功能请填写下方 Issue 编号；若还没有对应 Issue，请先自行创建。功能讨论请放在 Issue 中进行。
改动较大或方向性变更，请先在关联 Issue 中与维护者达成一致，再提交 PR。
Bug 修复请关联对应 Issue。设计取舍、理解偏差或预期不一致，更适合作为讨论或功能请求。
Closes 模型重定向时允许从上游拉取模型 #6101
🚀 变更类型 / Type of change
📝 变更描述 / Description
(简述做了什么、为什么生效。如果难以简述，建议先拆分范围，或在 Issue 中与维护者对齐。)
重新实现了旧版UI中在模型重定向设置中，从上游拉取模型填入的按钮
实现方式是为现有模型列表增加单选模式，因此自带结果缓存，可以保证操作的流畅性
附加更改：
📸 运行证明 / Proof of Work
(请写明如何验证：实际步骤与观察结果。UI 变更请附截图或录屏；Bug 修复请说明复现过程与修复后结果。)
旧版UI的图片：
新版UI的图片：
✅ 提交前检查项 / Checklist
New feature，我已关联对应 Issue；若尚无 Issue，我已先自行创建。Summary by CodeRabbit
New Features
Bug Fixes