Skip to content

chore(rtvision): sync upstream and prepare 0.0.86 - #97

Merged
kalvenschraut merged 66 commits into
rtvisionfrom
sync/upstream-20261018
Oct 18, 2026
Merged

kalvenschraut merged 66 commits into
rtvisionfrom
sync/upstream-20261018

Conversation

@kalvenschraut

Copy link
Copy Markdown
Member

Sync 62 upstream commits through 3ff5b3c82a62baddc0c2b1b227e9d3a06190c426 into rtvision and prepare patch release 0.0.86. Fork base is 019d696159b75e0ad0abe45be60937c0959dc1a7; previously integrated upstream is e6ced718a3bb35c58986b12fb9f84624974104c2. Both parent histories are preserved.

Upstream changes

  • Mobile can link, unlink, watch, and unwatch thread PRs. Android foldable layout and themed sheet headers improve.
  • Web and mobile reduce avoidable rendering, provider-status churn, and reconnect churn. Upstream enables React Compiler in Metro and migrates web React tests to real-browser tests.
  • Large databases start faster without full planner-statistics scans. Unused V1 projections are dropped from the V2 copy, and t3 doctor can remove the old database explicitly while preserving the current one.
  • Claude workflow members stream thinking/tool calls into their threads. Workflow openings display their phases and agents instead of the script.
  • Snoozed open threads wake correctly; time labels, Working-thread drag references, clipped-table toggles, and request-specific project errors are repaired.

Fork integration decisions

Use upstream caching, extracted components/hooks, stable timeline row contexts, and browser-test setup rather than retaining superseded fork implementations. Layer mobile CI-run details below upstream's richer linked-PR rows.

Keep RTVision Gitea/Forgejo integrations, registry and updater routing, Node/npm/OpenRC/Alpine/node-pty support, SSH/editor routing, release packaging, Vim navigation, browser profiles, richer PR review behavior and diff scroll retention, and scheduled-task model traits and permissions. The remaining fork-specific node-renderer tests still need their test-only dependencies/helpers; obsolete jsdom use is removed. No vendored reference content changed.

Gates

  • 614 focused tests pass: 81 persistence/doctor/workflow/state/version tests, 431 Claude/mobile/shared-state tests, and 102 fork regression/markdown policy tests.
  • Scoped web, mobile, server, and client-runtime typechecks pass. Targeted lint, formatting, and diff checks pass. Two inherited mobile memo-dependency warnings remain nonblocking.
  • SQLite subprocess test passed outside the sandbox. Sequential server typecheck passed after a resource-killed parallel attempt.
  • No browser/computer-use qualification was performed locally. CI owns the browser tests and repo-wide checks.
  • Exact-head independent Astra review, CodeRabbit coverage/approval decision, and applicable CI must pass before merge. Release build, asset/checksum, registry integrity, clean Node/Alpine/PTy and service-preflight gates remain after merge. No live deployment or restart is authorized.

Model: gpt-6.1-sol. Harness: Codex in T3 Code.

juliusmarminge and others added 30 commits October 17, 2026 01:03
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…hanges (pingdotgg#20819)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ngs row (pingdotgg#20830)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ry result row (pingdotgg#20817)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g the filter (pingdotgg#20840)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ing (pingdotgg#20838)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…r one port (pingdotgg#20875)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…fig pushes (pingdotgg#20852)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…row (pingdotgg#20854)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rs identical (pingdotgg#20855)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… changed (pingdotgg#20848)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… updates (pingdotgg#20853)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ole page (pingdotgg#20859)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ome (pingdotgg#20842)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… it (pingdotgg#20891)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#20892)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… and thread panels (pingdotgg#20823)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…presentation consumers (pingdotgg#20821)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… card and model row (pingdotgg#20851)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge and others added 13 commits October 18, 2026 00:06
…us returns (pingdotgg#21118)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…n unchanged preview list (pingdotgg#21130)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…nutes (pingdotgg#21122)

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…'s rows (pingdotgg#21123)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…21146)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…21147)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…alls into their threads (pingdotgg#20856)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…of its script (pingdotgg#20857)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 18, 2026
@kalvenschraut

Copy link
Copy Markdown
Member Author

@coderabbitai review

Please review exact candidate 536bcdc at the maintainer-requested high-level upstream integration scope. Review the changelog, selected conflict resolutions, retained fork behavior and obvious regressions, not exhaustive file-by-file or vendored reference content. If the 442-file diff exceeds reliable coverage, state the coverage limitation explicitly; a green check without substantive coverage is not approval.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review skipped: 440 files exceed the limit of 100.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions github-actions Bot added size:XXL 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Oct 18, 2026
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB −7 B (−0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB −7 B (−0.6%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 019d696 · PR result: 42d7d81 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@kalvenschraut

Copy link
Copy Markdown
Member Author

Final high-level primary review

SOURCE GO for ae5fb7dff21a4e30a3a9b4680b3ccd2ddeab0a1d at the maintainer-requested high-level integration scope. No unresolved blocking source findings identified. This is not yet merge or release readiness.

The candidate preserves merge 536bcdcdec1344046e1c3b8f6e8866d5f9b775f7 with ordered parents fork 019d696159b75e0ad0abe45be60937c0959dc1a7 and upstream 3ff5b3c82a62baddc0c2b1b227e9d3a06190c426. The pinned 62-commit upstream range starts after e6ced718a3bb35c58986b12fb9f84624974104c2. Remote fork and upstream tips were re-fetched and remain unchanged. Version 0.0.86 remains in all four release manifests.

Reviewed the changelog, selected integration/conflict resolutions, retained fork behavior, dependency changes and the targeted repair. Upstream caching, extracted components/hooks, stable timeline contexts and browser-test setup replace the older implementations. Retained fork behavior includes Gitea/Forgejo, registry/updater routing, Node/npm/OpenRC/Alpine/node-pty/SSH and packaging, route-aware editor permissions, Vim navigation, desktop profile lifetime, richer PR review/diff controls and scheduled-task permissions/model traits. Mobile CI details layer below upstream PR rows. No vendored reference content changed.

CI findings and repairs

Initial CI run 39149697037 passed all eight server shards, build/typecheck, release smoke, Rust and mobile static analysis. Its failures were not waived:

  • Shared PR rerun acknowledgement depended on data identity. Upstream now shares equal query data. Acknowledgement now follows successful response identity and ignores in-flight refreshes. Both original rerun regression cases failed in initial CI; a local pre-fix control with the updated regression timed out with exit 124. The fixed 78 PR-state tests and 37 query-runtime tests pass, including preservation of unchanged-data identity.
  • Removed an unused export after the obsolete renderer test was removed. Web-scoped export audit passes.
  • Windows file fixtures now include a thread so panel actions exist without an editor; preview fixtures pin the desktop profile; the permissions mock retains upstream's new link hook. Node synthetic-DOM diagnostics found the missing mock export, then passed 20 tests after repair. These diagnostics are not browser qualification. CI owns the actual browser suite.

Scoped web/client-runtime typechecks, six-file lint, formatting and diff checks pass. Prior focused suites passed 614 tests. No repo-wide local checks or browser/computer use were performed.

Independent review and CodeRabbit limitation

Astra round 1 gave GO on the previous candidate, with no source findings. It does not approve the repaired SHA. Fresh final-SHA round 2 is running under task:
node:delegated-task:command%3Amcp%3Af6fb80e7-27f2-4db9-af6b-1f94753c4f5f%3Adelegate-task%3Artvision-sync-20261018-ae5fb7d-astra-high-level-r2

CodeRabbit explicitly replied: "Review skipped: 440 files exceed the limit of 100." Its green check is not substantive approval. The maintainer-authorized large-diff fallback therefore applies, but requires fresh independent GPT-6 Astra GO on this exact candidate, this primary GO, all applicable CI passing and no unresolved blockers. No repeated full-review command will cure the file limit.

Merge remains gated on fresh Astra GO and current CI. Release build, all expected artifacts/checksums, exact-tarball registry publication/integrity, clean Node/service-preflight and Alpine/node-pty checks must pass before GitHub draft publication. No service deployment or restart.

Model: gpt-6.1-sol. Harness: Codex in T3 Code.

@kalvenschraut

Copy link
Copy Markdown
Member Author

High-level primary review, final fixture repair

SOURCE GO for ec14a6df8a94c37e55c57ab0eb9c175b8062a61a. No blocking source findings at the maintainer-requested high-level integration scope. CI, merge and release are still separate gates.

I renewed the prior review against the actual integration diff and changelog, selected timeline/settings conflicts, release manifests and dependencies. The pinned fork is 019d696159b75e0ad0abe45be60937c0959dc1a7, with 62 upstream commits from e6ced718a3bb35c58986b12fb9f84624974104c2 through 3ff5b3c82a62baddc0c2b1b227e9d3a06190c426. Both remote tips were refreshed and remain unchanged. Merge ancestry is intact, all four manifests are 0.0.86, .repos is unchanged, and the worktree is clean.

Upstream settings/rendering/query improvements remain adopted. The retained Gitea/Forgejo, registry/update routing, Node/npm/OpenRC/Alpine/node-pty/SSH, release packaging, Vim navigation, editor permissions, browser profiles, richer PR controls and scheduled-task behavior are unchanged by this repair.

Since the previous primary/Astra GO on ae5fb7d, only three test files changed. The repair preserves mock exports required by actual ESM dependencies instead of substituting incomplete namespaces. The editor-picker fixture now supplies router-link and menu context, opens the editor submenu, and selects the explicit preference-changing action. Existing permission, failed-open and successful-open assertions remain; no tests are skipped. A Node-only diagnostic reproduced four picker context failures, then an incorrect action selection. All 27 diagnostic tests now pass. Scoped web typecheck, three-file lint/format and diff checks pass. These synthetic DOM diagnostics are not browser qualification.

The preceding CI passed lint, build/typecheck, all eight server shards, release smoke, Rust and mobile analysis. Its web job still aborted in Vitest mock initialization. The missing ESM exports are confirmed by source inspection; the new CI run must establish whether they resolve that abort. Nothing here waives a failing check.

CodeRabbit explicitly skipped the large sync: "440 files exceed the limit of 100." Its green status is not approval. The authorized fallback still requires fresh exact-SHA Astra GO, this primary GO, passing applicable CI and no unresolved blockers. Fresh Astra round 3 task is node:delegated-task:command%3Amcp%3Af6fb80e7-27f2-4db9-af6b-1f94753c4f5f%3Adelegate-task%3Artvision-sync-20261018-ec14a6d-astra-high-level-r3.

No local browser/computer use, live userdata writes, service deployment or restart. Release publication remains gated on merged-head CI/build, expected installers/CLI/npm assets and checksums, registry integrity, clean Node/service preflight and Alpine/node-pty validation.

Model: gpt-6.1-sol. Harness: Codex in T3 Code.

@kalvenschraut

Copy link
Copy Markdown
Member Author

Independent GPT-6 Astra round 3 returned explicit SOURCE GO for exact candidate ec14a6d. It reviewed the actual integration diff, upstream changelog, selected integration/dependency changes and all three fixture repairs since round 2. No source blockers identified. Task receipt: node:delegated-task:command%3Amcp%3Af6fb80e7-27f2-4db9-af6b-1f94753c4f5f%3Adelegate-task%3Artvision-sync-20261018-ec14a6d-astra-high-level-r3. Together with the renewed primary GO above, this supplies the two exact-SHA source approvals for the authorized large-diff CodeRabbit fallback. CodeRabbit skipped over its 100-file limit; no bot approval is inferred. CI run 39151549185 remains the next gate. Merge and all post-merge release/artifact/npm/compatibility checks remain pending.

@kalvenschraut

Copy link
Copy Markdown
Member Author

Primary high-level review, keybinding fixture repair

SOURCE GO for exact candidate 42d7d810b060f11cafadbc497a690a761f3de561. No blocking source findings at the requested high-level integration scope. The integration reviewed in prior rounds remains intact; the only new delta is two browser-test fixtures, with no production changes or version/dependency changes since the prior approval.

The previous web run now completes instead of aborting during mock initialization: 8,095 tests pass and two keybinding-editor fixtures fail. Every other applicable CI job passed, including shared tests, all eight server shards, lint/build/typecheck, Rust/mobile static analysis and release smoke. The two fixture failures were reproduced in a Node-only diagnostic and are not waived.

The warning fixture now supplies the resolved local-exec route required by current editor dispatch. The settings fixture no longer mocks the obsolete useOpenInPreferredEditor path. It exercises actual editor dispatch, with a configured editor preference and a real permission atom in the registry, while mocking command transport. It checks the actual command payload and explicitly proves that the button is enabled before testing a grant-revocation click race. Existing denied-grant and settings-write-notice assertions remain. No production guards changed; no tests skipped.

All six tests pass both in the Node synthetic-DOM diagnostic and in the same diagnostic with React Compiler enabled. Scoped web typecheck, two-file lint/format and diff checks pass. CI still owns actual browser qualification.

Refreshed pins remain fork 019d696159b75e0ad0abe45be60937c0959dc1a7 and upstream 3ff5b3c82a62baddc0c2b1b227e9d3a06190c426, with 62 upstream commits after e6ced718a3bb35c58986b12fb9f84624974104c2. Merge ancestry, the four 0.0.86 manifests, previously reviewed upstream-first integration decisions and retained fork runtime/routing/packaging behavior are unchanged. No .repos changes. The checkout is clean.

CodeRabbit explicitly skipped the sync over its 100-file limit. Its green status is not approval. Fresh independent Astra review is running as task node:delegated-task:command%3Amcp%3Af6fb80e7-27f2-4db9-af6b-1f94753c4f5f%3Adelegate-task%3Artvision-sync-20261018-42d7d81-astra-high-level-r4. The authorized fallback still needs that exact-SHA GO, this primary GO, passing applicable CI and no blockers before merge. Release build/assets/checksums/npm integrity/clean Node/service preflight/Alpine-node-pty validation remain required after merge and before publication. No live deployment or restart.

Model: gpt-6.1-sol. Harness: Codex in T3 Code.

@kalvenschraut

Copy link
Copy Markdown
Member Author

Independent GPT-6 Astra R4 returned explicit SOURCE GO for exact final candidate 42d7d81, with no blocking findings at the requested high-level scope. It reviewed actual integration/changelog/selected conflicts and the full two-file fixture delta. It confirmed denial coverage, permission subscriptions, actual command payload, and enabled-before-revocation controls. Task receipt: node:delegated-task:command%3Amcp%3Af6fb80e7-27f2-4db9-af6b-1f94753c4f5f%3Adelegate-task%3Artvision-sync-20261018-42d7d81-astra-high-level-r4. This and the primary GO above renew both exact-SHA source approvals for the maintainer-authorized CodeRabbit large-diff fallback. CodeRabbit skipped over its file limit, not approved. Applicable current-head CI and all post-merge release gates remain required. PR watching continues.

@kalvenschraut

Copy link
Copy Markdown
Member Author

MERGE GO for reviewed head 42d7d81. Final readiness rechecked: correct RTVision fork and rtvision base 019d696, unchanged pinned upstream 3ff5b3c, clean/mergeable PR, no review threads or unresolved blocking findings. Primary and independent GPT-6 Astra R4 source GO name this exact head. CodeRabbit explicitly skipped the 440-file sync over its 100-file limit, so the maintainer-authorized high-level primary+Astra fallback applies. Exact-head CI39152521699 and applicable checks passed; transfer limits pass for both Codex and Claude. Merge will preserve upstream ancestry. Release publication is not yet approved by build evidence: merged-head CI/release build and all artifact/npm/Node/service/Alpine gates must still pass.

@kalvenschraut
kalvenschraut merged commit 130291c into rtvision Oct 18, 2026
26 checks passed
@kalvenschraut

Copy link
Copy Markdown
Member Author

Released 0.0.86

RTVision T3 Code 0.0.86 is published. @rtvision/t3@0.0.86 is the registry's latest version. Npm was published and verified before the GitHub draft was made public.

  • Exact merged/tagged head: 130291cf26c77fcdc2c0cbb83c87c04337bf5989. Its tree 8559c0a0228143f8f911ce793a3bff679b65b5f3 equals reviewed candidate 42d7d810b060f11cafadbc497a690a761f3de561. Upstream ancestry is preserved. No source changes followed the final reviews.
  • Primary GO and independent GPT-6 Astra GO cover that exact candidate at the requested high-level integration scope. CodeRabbit explicitly skipped 440 files over its 100-file limit. The authorized large-diff fallback was used; no bot approval is inferred.
  • Candidate CI, merged-head CI, and release build succeeded. The transfer-impact report passed every enforced ceiling. No unresolved blockers remain.
  • All 11 GitHub asset digests and all 10 SHA256SUMS entries passed. Updater metadata, installer payload integrity, npm/archive layouts and executable formats passed. Linux standalone version/HTTP-serve smoke and Windows CI's version/serve smoke passed. Published assets retain their verified IDs, sizes and digests.
  • Exact npm tarball SHA256: 40b8963d1e412bcd5eab96cdcd739fe093b9b42c5e64fe385198b20f3f32b482. Registry version/latest, SHA512 integrity, SHA1 shasum and downloaded bytes match the verified asset.
  • Clean tarball and registry installs passed on Node 24.22.0 with Debian glibc and Alpine musl. CLI version/help, protocol-3 service preflight, protocol-2 rejection and real node-pty spawn/output/exit passed. Alpine uses the retained npm_config_build_from_source=true setting and native build prerequisites. A control without that setting reproduced the unsafe glibc-prebuild crash, confirming why the fork path remains necessary. OpenRC availability and packaged Node service entry paths were checked; no daemon installation or boot is claimed.

The release notes summarize the 62 upstream commits, upstream replacements, retained fork behavior and validation boundaries. Full receipts remain under /tmp/rtvision-sync-20261018-evidence/release-final-receipt.json in the owning workspace. No live service was restarted or deployed, no local browser was launched, and no full desktop GUI qualification is claimed. No release gate remains pending.

Model: gpt-6.1-sol. Harness: Codex in T3 Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants