Skip to content

Add rosbag2-storage-mcap on linux-64 and win-64 - #205

Closed
mvarble wants to merge 5 commits into
RoboStack:mainfrom
mvarble:main
Closed

mvarble wants to merge 5 commits into
RoboStack:mainfrom
mvarble:main

Conversation

@mvarble

@mvarble mvarble commented Aug 23, 2024

Copy link
Copy Markdown

I added pid-controller and rosx-introspection to ignored packages, because they for some reason get included in my vinca recipe and fail during build and have nothing to do with rosbag2-storage-mcap.

The pid-controller fails when missing header control_msgs/msg/multi_dof_command.hpp. The build environment has an old version of control_msgs which does not include this message. I would happily help bumping control_msgs, but vinca seems pretty blind to me adding it to the dependencies; I don't know what is going on there.

The rosx-introspection fails when missing header rapidjson/document.h. I tried experimenting with adding it to various files like ./env/robostackenv.yaml, ./conda_build_config.yaml, and ./.ci_support/conda_forge_pinnings.yaml to no avail, so I also gave up on understanding where I mess with vinca to include this library in the build.

@mvarble

mvarble commented Sep 9, 2024

Copy link
Copy Markdown
Author

Can you by chance CI check? It seems that the action failed from a timeout.

@mvarble

mvarble commented Dec 30, 2024

Copy link
Copy Markdown
Author

Can you merge now that it passes?

@traversaro

Copy link
Copy Markdown
Member

Can you merge now that it passes?

Thanks for the ping @mvarble ! Probably it is better to either integrate in #229 .

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

See #229 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants