Skip to content

Finish documenting code in rocketpyAlpha.py #6

Description

@giovaniceotto

The code in nbks/rocketpyAlpha.py is not fully documented. Methods in classes Motor, Rocket and Flight are missing docstring documentation.

Activity

  1. giovaniceotto commented on Sep 10, 2018

    @giovaniceotto
    MemberAuthor

    Methods with missing documentation are:

    • Motor

      • refresh
      • reshapeThrustCurve
      • info - Should be simplied and allInfo should be created
      • evaluateTotalImpulse
      • evaluateExhaustVelocity
      • evaluateMassDot
      • evaluateMass
      • evaluateGeometry
      • evaluateInertia
      • __burnRate
      • importEng
      • exportEng
    • Rocket

      • info - Should be simplified and allInfo should be created
      • refresh
      • evaluateReducedMass
      • evaluateTotalMass
      • serMotor
      • refreshStaticMargin
      • addCMExcentricity
      • addCPExcentricity
      • addMotorExcentricity
    • Flight

      • postProcess
      • info
      • allInfo
      • animate - Should be removed, not working well
      • __uDotRailOpt - Opt suffix should be removed, as this is the standard implementation
      • __uDotOpt - Opt suffix should be removed, as this is the standard implementation
      • __uDotDrogue - Should be removed, replaced by uDotParachute
      • __uDotMain - Should be removed, replaced by uDotParachute
      • __uDotParachute
  2. giovaniceotto commented on Sep 15, 2018

    @giovaniceotto
    MemberAuthor

    Methods documented in branch complete_documentation as of today are:

    • Motor

      • refresh - Removed - Does not make sense to have in current Motor implementation, should be replaced by more efficient version later
      • reshapeThrustCurve - Documented
      • evaluateTotalImpulse - Documented
      • evaluateExhaustVelocity - Documented
      • evaluateMassDot - Documented - Also made significantly more time efficient (~100x) by replacing setDiscrete usage by more elementary methods
      • evaluateMass - Documented - Also made significantly more time efficient (~100x) by replacing integrate.odeint usage by trapezoidal rule, which gives the same result to 1e-7 accuracy
      • evaluateGeometry - Documented
      • evaluateInertia - Documented - Can be made much more efficient by replacing setDiscrete by more elementary methods or fixing issue #8
      • __burnRate - Removed - Was rewritten inside evaluateGeometry under the name geometryDot to speed up execution and eliminate the only private method
      • importEng - Documented
      • exportEng - Documented
      • info - Documented
      • allInfo - Documented
    • Rocket

      • info - Should be simplified and allInfo should be created
      • refresh
      • evaluateReducedMass
      • evaluateTotalMass
      • serMotor
      • refreshStaticMargin
      • addCMExcentricity
      • addCPExcentricity
      • addMotorExcentricity
    • Flight

      • postProcess
      • info
      • allInfo
      • animate - Should be removed, not working well
      • __uDotRailOpt - Opt suffix should be removed, as this is the standard implementation
      • __uDotOpt - Opt suffix should be removed, as this is the standard implementation
      • __uDotDrogue - Should be removed, replaced by uDotParachute
      • __uDotMain - Should be removed, replaced by uDotParachute
      • __uDotParachute
  3. giovaniceotto commented on Sep 16, 2018

    @giovaniceotto
    MemberAuthor

    Methods documented in branch complete_documentation as of today are:

    • Motor

      • refresh - Removed - Does not make sense to have in current Motor implementation, should be replaced by more efficient version later
      • reshapeThrustCurve - Documented
      • evaluateTotalImpulse - Documented
      • evaluateExhaustVelocity - Documented
      • evaluateMassDot - Documented - Also made significantly more time efficient (~100x) by replacing setDiscrete usage by more elementary methods
      • evaluateMass - Documented - Also made significantly more time efficient (~100x) by replacing integrate.odeint usage by trapezoidal rule, which gives the same result to 1e-7 accuracy
      • evaluateGeometry - Documented
      • evaluateInertia - Documented - Can be made much more efficient by replacing setDiscrete by more elementary methods or fixing issue #8
      • __burnRate - Removed - Was rewritten inside evaluateGeometry under the name geometryDot to speed up execution and eliminate the only private method
      • importEng - Documented
      • exportEng - Documented
      • info - Documented
      • allInfo - Documented
    • Rocket

      • refresh - Removed - Does not make sense to have in current Rocket implementation, should be replaced by more efficient version later
      • evaluateReducedMass - Documented - Can be made 100x more efficient by replacing setDiscrete by more elementary methods or fixing issue #8
      • evaluateTotalMass - Documented - Can be made 100x more efficient by replacing setDiscrete by more elementary methods or fixing issue #8
      • evaluateStaticMargin - Documented - Replaced refreshStaticMargin
      • setMotor - Removed - Does not make sense to have in current Rocket implementation, should be replaced by more suited version later
      • addCMExcentricity - Documented
      • addCPExcentricity - Documented
      • addMotorExcentricity - Documented
      • info - Documented
      • allInfo - Documented
    • Flight

      • postProcess
      • info
      • allInfo
      • animate - Should be removed, not working well
      • __uDotRailOpt - Opt suffix should be removed, as this is the standard implementation
      • __uDotOpt - Opt suffix should be removed, as this is the standard implementation
      • __uDotDrogue - Should be removed, replaced by uDotParachute
      • __uDotMain - Should be removed, replaced by uDotParachute
      • __uDotParachute
  4. giovaniceotto commented on Sep 17, 2018

    @giovaniceotto
    MemberAuthor

    I have also added a list of attributes to the Motor class. Would be nice to do the same for the other classes.

  5. giovaniceotto commented on Sep 18, 2018

    @giovaniceotto
    MemberAuthor

    List of attributes also added to Environment class.

  6. giovaniceotto commented on Sep 19, 2018

    @giovaniceotto
    MemberAuthor

    List of attributes also added to Rocket class.

  7. giovaniceotto commented on Sep 19, 2018

    @giovaniceotto
    MemberAuthor

    Methods documented in branch complete_documentation as of today are:

    • Motor

      • refresh - Removed - Does not make sense to have in current Motor implementation, should be replaced by more efficient version later
      • reshapeThrustCurve - Documented
      • evaluateTotalImpulse - Documented
      • evaluateExhaustVelocity - Documented
      • evaluateMassDot - Documented - Also made significantly more time efficient (~100x) by replacing setDiscrete usage by more elementary methods
      • evaluateMass - Documented - Also made significantly more time efficient (~100x) by replacing integrate.odeint usage by trapezoidal rule, which gives the same result to 1e-7 accuracy
      • evaluateGeometry - Documented
      • evaluateInertia - Documented - Can be made much more efficient by replacing setDiscrete by more elementary methods or fixing issue #8
      • __burnRate - Removed - Was rewritten inside evaluateGeometry under the name geometryDot to speed up execution and eliminate the only private method
      • importEng - Documented
      • exportEng - Documented
      • info - Documented
      • allInfo - Documented
    • Rocket

      • refresh - Removed - Does not make sense to have in current Rocket implementation, should be replaced by more efficient version later
      • evaluateReducedMass - Documented - Can be made 100x more efficient by replacing setDiscrete by more elementary methods or fixing issue #8
      • evaluateTotalMass - Documented - Can be made 100x more efficient by replacing setDiscrete by more elementary methods or fixing issue #8
      • evaluateStaticMargin - Documented - Replaced refreshStaticMargin
      • setMotor - Removed - Does not make sense to have in current Rocket implementation, should be replaced by more suited version later
      • addCMExcentricity - Documented
      • addCPExcentricity - Documented
      • addMotorExcentricity - Documented
      • info - Documented
      • allInfo - Documented
    • Flight

      • postProcess - Documented
      • __uDotRail - Documented - Opt suffix removed
      • __uDot - Documented - Opt suffix removed
      • __uDotParachute - Documented
      • info - Documented
      • allInfo - Documented
      • animate - Quarantined as not implemented
      • __uDotDrogue - Removed - Replaced by uDotParachute
      • __uDotMain - Removed - Replaced by uDotParachute
  8. giovaniceotto commented on Sep 19, 2018

    @giovaniceotto
    MemberAuthor

    List of attributes also added to Flight class.

  9. added a commit that references this issue on Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DocsDocs and examples related

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions