Skip to content

Export function to csv complete - #250

Closed
brunosorban wants to merge 2 commits into
developfrom
enh/dispersion_results_to_csv
Closed

brunosorban wants to merge 2 commits into
developfrom
enh/dispersion_results_to_csv

Conversation

@brunosorban

@brunosorban brunosorban commented Oct 3, 2022 •

Copy link
Copy Markdown
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

There is no function to export dispersion data to csv.

What is the new behavior?

A export function from dispersion results dictionary to a csv was added.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Enter text here...

@brunosorban brunosorban self-assigned this Oct 3, 2022
@brunosorban brunosorban added the Enhancement New feature or request, including adjustments in current codes label Oct 3, 2022
@Gui-FernandesBR Gui-FernandesBR added this to the RocketPy at EuroC 2022 milestone Oct 4, 2022
@Gui-FernandesBR Gui-FernandesBR linked an issue Oct 4, 2022 that may be closed by this pull request
5 tasks
@brunosorban
brunosorban changed the base branch from master to develop October 4, 2022 12:51
@Gui-FernandesBR Gui-FernandesBR removed this from the RocketPy at EuroC 2022 milestone Oct 24, 2022
@MateusStano MateusStano added this to the Release v1.0.0 milestone Oct 30, 2022
@Gui-FernandesBR

Copy link
Copy Markdown
Member

Great simple addition by Brunao!! Thank you, man

However, I think this can be solved in a more complete way if we consider the new Dispersion class (not 100% sure on how to do that).

I would say to create another PR instead of moving forward with this one. @MateusStano your opinion is important here as well.

@MateusStano

Copy link
Copy Markdown
Member

Done in PR #366

@Gui-FernandesBR
Gui-FernandesBR deleted the enh/dispersion_results_to_csv branch July 5, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request, including adjustments in current codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants