Repository navigation
ssh-key: accept undersized mpints in ECDSA signatures - #291
Merged
Merged
Conversation
mkeeter
force-pushed
the
ecdsa-short-mpint
branch
from
August 29, 2024 13:41
48bce59 to
65a8c4a
Compare
mkeeter
force-pushed
the
ecdsa-short-mpint
branch
from
August 29, 2024 13:52
65a8c4a to
394b6e1
Compare
tarcieri
reviewed
Sep 5, 2024
tarcieri
reviewed
Sep 5, 2024
tarcieri
approved these changes
Sep 5, 2024
Contributor
Author
|
Thanks for merging this and #289 ! Are you planning to make a new patch release of |
Member
|
The |
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 4, 2024
labbott
added a commit
to oxidecomputer/sshauth
that referenced
this pull request
Oct 8, 2024
Brings in fix RustCrypto/SSH#291 and RustCrypto/SSH#289
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 15, 2024
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 15, 2024
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 15, 2024
Merged
labbott
added a commit
to oxidecomputer/sshauth
that referenced
this pull request
Oct 17, 2024
This brings in fixes RustCrypto/SSH#291 and RustCrypto/SSH#289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leading zeros must be stripped from
mpintvalues (per RFC 4251), meaning it's possible to see "short"mpintvalues when using them to construct signatures.These values must be padded with leading zeros before being used in
pXYZ::ecdsa::Signature, which expect exact-size arrays.See #290 for details.