Repository navigation
Fix issue #2811 spurious rebuilds due to incorrect waiting_parents on nodes when builder has more than one target and source file generated - #3340
Merged
bdbaddog merged 13 commits intoApr 27, 2019
Conversation
…ts on nodes when builder has more than one target and source file generated
…111_multiple_targets_via_emitter_spurious_rebuilds
bdbaddog
marked this pull request as ready for review
April 26, 2019 15:29
…mitter_spurious_rebuilds
…gets_via_emitter_spurious_rebuilds' into fix_mongo_bug_33111_multiple_targets_via_emitter_spurious_rebuilds
garyo
reviewed
Apr 26, 2019
| for parent in self.waiting_parents: | ||
| parent.implicit = None | ||
|
|
||
| # Handle issue where builder emits more than one target and |
Contributor
There was a problem hiding this comment.
This looks fine to me. I guess my only question would be why aren't the other targets already in waiting_parents so they get cleared above? (Just curious)
Contributor
Author
There was a problem hiding this comment.
It's a combination of the first target hit by the taskmaster walk and the fact that the N targets aren't linked. I'm going to continue looking at this, but this fix resolves a long standing issue so accepting the good enough, and then will continue working on the maybe better solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #2811
Reproducing this issue requires the following.
with the compiler at the beginning of the implicit list and the rest of the scanned files added to that list.
Nth target's implicit lists changing when compared to SConsign's which have been loaded.
Contributor Checklist:
master/src/CHANGES.txtdirectory (and read theREADME.txtin that directory)