Repository navigation
Upgrade RuboCop related gems and Tapioca - #3069
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
marked this pull request as ready for review
January 15, 2025 20:13
vinistock
force-pushed
the
upgrade_rubocop
branch
from
January 15, 2025 20:15
0cc865b to
b92d420
Compare
vinistock
force-pushed
the
01-15-change_our_internal_rubocop_integration_identifier
branch
from
January 15, 2025 20:45
b6f67d1 to
9793189
Compare
vinistock
force-pushed
the
upgrade_rubocop
branch
from
January 15, 2025 20:45
b92d420 to
04431a5
Compare
vinistock
force-pushed
the
01-15-change_our_internal_rubocop_integration_identifier
branch
from
January 15, 2025 21:05
9793189 to
fe108cd
Compare
vinistock
force-pushed
the
upgrade_rubocop
branch
6 times, most recently
from
January 16, 2025 14:43
48c492a to
552ad47
Compare
andyw8
approved these changes
Jan 16, 2025
vinistock
force-pushed
the
upgrade_rubocop
branch
from
January 16, 2025 14:50
552ad47 to
398326e
Compare
vinistock
force-pushed
the
01-15-change_our_internal_rubocop_integration_identifier
branch
from
January 16, 2025 14:56
fe108cd to
798e8a1
Compare
vinistock
force-pushed
the
upgrade_rubocop
branch
from
January 16, 2025 14:56
398326e to
1875ab2
Compare
vinistock
changed the base branch from
01-15-change_our_internal_rubocop_integration_identifier
to
graphite-base/3069
January 16, 2025 15:23
vinistock
force-pushed
the
upgrade_rubocop
branch
from
January 16, 2025 15:23
1875ab2 to
75bc45a
Compare
vinistock
force-pushed
the
graphite-base/3069
branch
from
January 16, 2025 15:23
798e8a1 to
125f722
Compare
vinistock
force-pushed
the
upgrade_rubocop
branch
from
January 16, 2025 15:24
75bc45a to
a3fa440
Compare
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I wanted to upgrade RuboCop to the latest version so that we can verify #3067 is working. After upgrading, I noticed that Tapioca was broken because of our version of Bundler, which is fixed in a recent release - so I upgraded that too.
Then I updated our gem RBIs and fixed any issues. I split commit by commit to make it easier to review.