Repository navigation
Conversation
rb_str_format always allocates its result with rb_str_buf_new, so the result is a plain String even when the receiver is a subclass. Fixes Shopify#1085 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
femto
force-pushed
the
zjit-string-format-stringexact
branch
from
October 22, 2026 13:23
839938f to
4b3e94d
Compare
|
PRs should be to ruby/ruby, not Shopify/ruby. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1085
String#%(rb_str_format_m) always allocates its result withrb_str_buf_newinrb_str_format, so the result is a plainStringeven when the receiver is a subclass. This annotates it incruby_methods.rsand adds an HIR opt test:🤖 Generated with Claude Code