Skip to content

Browser rounding - #164

Merged
lboeman merged 2 commits into
SolarPerformanceInsight:mainfrom
lboeman:browser-rounding
Mar 8, 2021
Merged

lboeman merged 2 commits into
SolarPerformanceInsight:mainfrom
lboeman:browser-rounding

Conversation

@lboeman

@lboeman lboeman commented Mar 8, 2021

Copy link
Copy Markdown
Contributor

Remove the floating point noise from the values in inverter/module database values as requested in #88.
Creates a fixed-precision decimal string and parses a float from the value. The first few results from the inverter database match the csv in pvlib.

Before rounding values:
Screenshot from 2021-03-08 12-05-06

After rounding values:
Screenshot from 2021-03-08 12-06-12

@codecov

codecov Bot commented Mar 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #164 (3d30470) into main (c6ae6be) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   86.77%   86.79%   +0.01%     
==========================================
  Files          83       83              
  Lines        3259     3263       +4     
  Branches      275      275              
==========================================
+ Hits         2828     2832       +4     
  Misses        386      386              
  Partials       45       45              
Flag Coverage Δ
javascript 74.74% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dashboard/src/components/Browser.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ae6be...8b04ed0. Read the comment docs.

@lboeman
lboeman requested a review from wholmgren March 8, 2021 19:45
@wholmgren wholmgren mentioned this pull request Mar 8, 2021
9 of 14 tasks
@lboeman
lboeman merged commit 4e81cd4 into SolarPerformanceInsight:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants