Repository navigation
Automatic Module Names - #105
Merged
Merged
Conversation
Closed
Contributor
Author
|
I may have a work around to prevent the renaming of the above mentioned package. I will play with it and report what I find. |
Contributor
Author
|
OK, I have finally convinced myself that the new package change to keep backwards compatibility is in compliance with java module system. This should be good to go and keep backwards compatibility. |
tlf30
force-pushed
the
automatic-module-names
branch
from
January 17, 2022 18:26
dc4ba93 to
defd8d7
Compare
|
With backwards compatibility continuing, this pr should be ready for merge, right? |
Contributor
Author
|
Yes, i believe it is ready. If someone would like to test it please do so. It worked on my test project. |
Owner
|
LGTM! Looks like a great compromise. |
1 of 2 tasks
SpaiR
pushed a commit
that referenced
this pull request
Oct 26, 2026
generateLibs' Linux target has always been constructed via newDefaultTarget(Os.Linux, Bitness._64), which defaults to Architecture.x86 regardless of host architecture. That's the root cause behind #105: even on a native aarch64 host, the task emits x86-only compiler flags (-mfpmath=sse -msse -m64), which a real aarch64 g++/gcc rejects outright. gdx-jnigen 2.5.2 (the library this build script sits on top of) already ships a correct Architecture.ARM Linux target (aarch64-linux-gnu- prefix, -fPIC, no SSE flags) — this task just never selects it. Add an opt-in `linuxarm64` env (mirroring the existing `macosarm64` convention) that builds via that target instead, refactoring the existing x86 Linux target into a shared createLinuxTarget() helper (mirroring createMacTarget()) so both paths stay in sync. libName is pinned to libimgui-java64.so on both architectures for consistency, matching how the mac target already does this for x86_64/arm64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds support for Automatic Module Names added by the Java Module System.
This PR was specifically designed after the conversation from #91.
The modules are as follows (and now listed in the readme):
Significant breaking changeThe packages
imgui.glfwandimgui.gl3have been renamed toimgui.lwjgl3.glfwandimgui.lwjgl3.gl3This will break any applications using
ImGuiImplGlfwandImGuiImplGl3.Unfortunately, this is a required change as no two modules can have the same classpath.
Please review and let me know what you think.
Thank you,
Trevor
Pinning @SpaiR and @Frooastside
EDIT: As a bonus, I slipped in that if no signing key is defined that signing will be disabled. This allows for publishing to the local maven repo.