Skip to content

Remove mistral - #313

Merged
nmaludy merged 5 commits into
masterfrom
feature/remove-mistral
Aug 18, 2020
Merged

nmaludy merged 5 commits into
masterfrom
feature/remove-mistral

Conversation

@nmaludy

@nmaludy nmaludy commented Aug 17, 2020

Copy link
Copy Markdown
Member

Closes #312

Removes Mistral and PostgreSQL.

I also updated the build dependencies now that we removed some modules.

@nmaludy
nmaludy requested review from arm4b and punkrokk August 17, 2020 14:00
@nmaludy nmaludy self-assigned this Aug 17, 2020
@nmaludy
nmaludy force-pushed the feature/remove-mistral branch from 660f2ac to fe57d1f Compare August 17, 2020 14:02
@nmaludy
nmaludy requested a review from amanda11 August 17, 2020 17:03
@amanda11

Copy link
Copy Markdown

LGTM but would like someone else to review. Some queries:

  • Is the postgreSQL reference in test/README.md still required?
  • Is the mistral_bootstrapped still required in spec/helpers/fact_helper.rb

@arm4b arm4b mentioned this pull request Aug 17, 2020
22 of 25 tasks
@nmaludy

nmaludy commented Aug 18, 2020

Copy link
Copy Markdown
Member Author

@amanda11 i removed the fact and yes the postgresql reference is still valid there, it's more about module architecture rather than using postgresql itself. Thanks for the review!

@nmaludy
nmaludy force-pushed the feature/remove-mistral branch from ea8bb9a to 2578817 Compare August 18, 2020 01:42

@arm4b arm4b left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmaludy
nmaludy merged commit 4a07a75 into master Aug 18, 2020
@nmaludy
nmaludy deleted the feature/remove-mistral branch August 18, 2020 11:06
bishopbm1 pushed a commit to EncoreTechnologies/puppet-st2 that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for Mistral

3 participants