Skip to content

Update and reword README.md - #5023

Merged
nmaludy merged 8 commits into
masterfrom
update-readme
Oct 1, 2020
Merged

nmaludy merged 8 commits into
masterfrom
update-readme

Conversation

@blag

@blag blag commented Aug 12, 2020 •

Copy link
Copy Markdown
Contributor

I noticed that the README hadn't been updated in awhile, so I tweaked some of the language, fixed a few grammatical issues, removed the broken Slack badge, and added a few more badges.

You can see the final rendered product by looking at the update-readme branch:
https://github.com/StackStorm/st2/tree/update-readme

TODO:

  • Tests (just kidding)
  • Update screenshot and linked YouTube video
  • Update architecture diagram to remove Mistral

Edit: Updated TODO since I'm not going to have time to record a new YouTube video.

@pull-request-size pull-request-size Bot added the size/M PR that changes 30-99 lines. Good size to review. label Aug 12, 2020
Comment thread README.md
@arm4b arm4b added this to the 3.3.0 milestone Sep 15, 2020
@arm4b

arm4b commented Sep 15, 2020

Copy link
Copy Markdown
Member

Following the #4762 (comment), just changed the reference to the new diagram you shared.

@blag is there anything else we need to merge this?

@arm4b
arm4b requested review from amanda11 and winem September 15, 2020 15:07

@amanda11 amanda11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just had a few comments that you may or may not agree with.

Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md
@blag
blag marked this pull request as ready for review September 15, 2020 20:28
@blag blag mentioned this pull request Sep 15, 2020
22 of 25 tasks
Comment thread README.md
* **Rules** map triggers to actions (or to workflows), applying matching criterias and map trigger payload data to action inputs.

* **Workflows** stitch actions together into “uber-actions”, defining the order, transition conditions, and passing the data. Most automations are more than one-step and thus need more than one action. Workflows, just like “atomic” actions, are available in action library, can be invoked manually or triggered by rules.
* **Workflows** stitch actions together into "uber-actions", defining the order, transition conditions, and passing context data from one action to the next. Most automations are multi-step (eg: more than one action). Workflows, just like "atomic" actions, are available in the action library, and can be invoked manually or triggered by rules.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the workflows then shouldn't eg: be eg. ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct form for the "For example" abbreviation is e.g.

@arm4b

arm4b commented Sep 29, 2020

Copy link
Copy Markdown
Member

@blag There seems to be some very minor changes left to merge this doc update PR. It's part of the v3.3 Mistral Deprecation plan and I think would close the #4762.

Comment thread README.md
* **Rules** map triggers to actions (or to workflows), applying matching criterias and map trigger payload data to action inputs.

* **Workflows** stitch actions together into “uber-actions”, defining the order, transition conditions, and passing the data. Most automations are more than one-step and thus need more than one action. Workflows, just like “atomic” actions, are available in action library, can be invoked manually or triggered by rules.
* **Workflows** stitch actions together into "uber-actions", defining the order, transition conditions, and passing context data from one action to the next. Most automations are multi-step (eg: more than one action). Workflows, just like "atomic" actions, are available in the action library, and can be invoked manually or triggered by rules.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Workflows** stitch actions together into "uber-actions", defining the order, transition conditions, and passing context data from one action to the next. Most automations are multi-step (eg: more than one action). Workflows, just like "atomic" actions, are available in the action library, and can be invoked manually or triggered by rules.
* **Workflows** stitch actions together into "uber-actions", defining the order, transition conditions, and passing context data from one action to the next. Most automations are multi-step (e.g. more than one action). Workflows, just like "atomic" actions, are available in the action library, and can be invoked manually or triggered by rules.

@nmaludy
nmaludy merged commit 034e2d1 into master Oct 1, 2020
@nmaludy
nmaludy deleted the update-readme branch October 1, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation enhancement size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants