Skip to content

Maybe pull in another fork #34

Closed as duplicate
Closed as duplicate

Description

@kaste

Hi @ykqmain, you made the last commit here, not the merge but the commit. Have you checked the other fork https://github.com/gotcha9999/ColorHighlight, also as PR #28. Isn't that useful too?

🍏

Activity

  1. ykqmain commented on Jun 17, 2025

    @ykqmain
    Contributor

    My commit is mainly for fixing bugs to make the plugin usable on Sublime Text 4200, I don't understand that PR (I see the plugin name has been changed).

  2. transferred this issue fromon Sep 8, 2025
  3. FichteFoll commented on Sep 8, 2025

    @FichteFoll
    Member

    After taking a brief look, 12763d3 is the only new commit and it appears to update the parsing logic for some newer color syntax, like making commas optional and supporting / as the alpha separator. Seems like rgba(white, 20%) is not supported anymore, but I haven't checked this further.

  4. ykqmain commented on Sep 9, 2025

    @ykqmain
    Contributor

    @FichteFoll

    This change modifies the plugin name and version number, adds the author's tag gotcha9999, enhances modern color syntax support, and removes outdated syntax, etc.

    I think changing the plugin name is unnecessary, I suggest closing this PR and first complete the migration and release a new version.

    If there is a need for maintenance in the future, it can be resubmitted.

  5. FichteFoll commented on Sep 9, 2025

    @FichteFoll
    Member

    This is not a PR, it is a commit on another fork. Obviously we would not pull that in as-is since it has some changes we do not want, but the other changes may be interesting.

    That said, we already have an issue for this in #19 and the fork with the commit I cited is referenced there as well, so I'm closing this as a duplicate.

  6. kaste commented on Sep 9, 2025

    @kaste
    Author

    Totally confusing, but it is also a PR -> #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions