Repository navigation
Build static TA-Lib C source - #772
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to "building from source" inspired by #770.
[NEW]: Source builds download and verify TA-Lib C 0.8.1, build it as a
static library and link it into the extension. A compiler, CMake and network
access are required; a separate TA-Lib C installation is no longer needed.
Generated C files remain included in source distributions.
[CHANGE]: Setting
TA_INCLUDE_PATHorTA_LIBRARY_PATHuses an existingTA-Lib C installation instead, without downloading or building the C library.
If only one is set, the other uses the standard search paths.
[CHANGE]: Wheels statically link TA-Lib C through the same build process.