Skip to content

fix: report intent.skills entries that name a missing skill - #315

Merged
LadyBluenotes merged 3 commits into
mainfrom
fix/removed-skill-permission-notice
Oct 4, 2026
Merged

LadyBluenotes merged 3 commits into
mainfrom
fix/removed-skill-permission-notice

Conversation

@LadyBluenotes

@LadyBluenotes LadyBluenotes commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

  • An intent.skills entry can name one exact skill, such as @tanstack/query#fetching. When the package was installed but no longer shipped a skill with that name, the entry permitted nothing and Intent reported nothing, so a removed or renamed skill disappeared without an explanation.
  • Intent now reports that entry with the existing notice: "@tanstack/query#fetching" is declared in intent.skills but was not discovered.
  • Permissions do not change. A skill that the package ships but intent.exclude hides is not reported.
  • The check stays inside the existing loop over configured entries, with no added file system call, import, or scan. The built package grows by 137 bytes.
  • Docs: the configuration concept page and the intent list reference state when the notice appears.
  • Adds a patch changeset.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr (run pnpm build:all first).

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot

changeset-bot Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bc98ff0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/intent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ec2fc656-8432-4f0f-81ef-7308948ef4ce
📥 Commits

Reviewing files that changed from the base of the PR and between c16a6a8 and bc98ff0.

📒 Files selected for processing (5)
  • .changeset/removed-skill-permission-notice.md
  • docs/cli/intent-list.md
  • docs/concepts/configuration.md
  • packages/intent/src/core/source-policy.ts
  • packages/intent/tests/source-policy.test.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7b61f7a

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 1m 1s View ↗
nx run-many --targets=build ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-04 17:57:40 UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@315

commit: bc98ff0

@codspeed

codspeed Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing fix/removed-skill-permission-notice (bc98ff0) with main (c16a6a8)

Open in CodSpeed

@LadyBluenotes
LadyBluenotes merged commit f7619bf into main Oct 4, 2026
9 checks passed
@LadyBluenotes
LadyBluenotes deleted the fix/removed-skill-permission-notice branch October 4, 2026 17:59
@github-actions github-actions Bot mentioned this pull request Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant