Skip to content

refactor(router-core): strip internal types from public build #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sheraff merged 3 commits into from
Aug 10, 2025
Merged

refactor(router-core): strip internal types from public build #4907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d06131
refactor(router-core): strip internal types from public build
Sheraff Aug 10, 2025
140f4b2
ci: apply automated fixes
autofix-ci[bot] Aug 10, 2025
52a8552
InferFoo types are not internal to router-core, used in react-router
Sheraff Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/router-core/src/Matches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,14 @@ export interface RouteMatch<
searchError: unknown
updatedAt: number
loadPromise?: ControlledPromise<void>
/** @internal */
beforeLoadPromise?: ControlledPromise<void>
/** @internal */
loaderPromise?: ControlledPromise<void>
loaderData?: TLoaderData
/** @internal */
__routeContext: Record<string, unknown>
/** @internal */
__beforeLoadContext?: Record<string, unknown>
context: TAllContext
search: TFullSearchSchema
Expand Down
12 changes: 6 additions & 6 deletions packages/router-core/src/typePrimitives.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export type ValidateParams<
> = PathParamOptions<TRouter, TFrom, TTo>

/**
* @internal
* @private
*/
export type InferFrom<
TOptions,
Expand All @@ -48,7 +48,7 @@ export type InferFrom<
: TDefaultFrom

/**
* @internal
* @private
*/
export type InferTo<TOptions> = TOptions extends {
to: infer TTo extends string
Expand All @@ -57,7 +57,7 @@ export type InferTo<TOptions> = TOptions extends {
: undefined

/**
* @internal
* @private
*/
export type InferMaskTo<TOptions> = TOptions extends {
mask: { to: infer TTo extends string }
Expand Down Expand Up @@ -131,7 +131,7 @@ export type ValidateId<
> = ConstrainLiteral<TId, RouteIds<TRouter['routeTree']>>

/**
* @internal
* @private
*/
export type InferStrict<TOptions> = TOptions extends {
strict: infer TStrict extends boolean
Expand All @@ -140,7 +140,7 @@ export type InferStrict<TOptions> = TOptions extends {
: true

/**
* @internal
* @private
*/
export type InferShouldThrow<TOptions> = TOptions extends {
shouldThrow: infer TShouldThrow extends boolean
Expand All @@ -149,7 +149,7 @@ export type InferShouldThrow<TOptions> = TOptions extends {
: true

/**
* @internal
* @private
*/
export type InferSelected<TOptions> = TOptions extends {
select: (...args: Array<any>) => infer TSelected
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"resolveJsonModule": true,
"skipLibCheck": true,
"strict": true,
"stripInternal": true,
"target": "ES2020"
},
"include": ["eslint.config.js", "prettier.config.js", "scripts"]
Expand Down