fix(router-core): support parsed params in matchRoute by LadyBluenotes · Pull Request #7776 · TanStack/router

LadyBluenotes · 2026-07-10T23:59:44Z

matchRoute now resolves matches through the processed route tree.

Applies route params.parse results before comparing or returning params.
Preserves parsed parent params for child parsers and handles repeated param names.
Uses route precedence and parser rejection during matching, so lower-priority or rejected routes no longer match through raw path templates.
Replaces findSingleMatch and its cache with findRouteMatch.
Normalizes exact trailing-slash matching while leaving fuzzy matching unchanged.
Keeps caseSensitive, basepath, search, pending, optional-param, and wildcard behavior covered.

matchRoute now returns false for destination templates that are not registered in the route tree.

Includes the reproducer from #2460.

Closes #2450.

Summary by CodeRabbit

Bug Fixes
- Fixed route matching to fully respect custom typed params.parse/params.stringify, including proper numeric conversions.
- matchRoute now returns parsed parameters (not raw strings) and correctly fails when typed parsing is rejected or throws.
- Improved matching consistency across nested routes, including search and trailing-slash behavior.
Tests
- Added/expanded matchRoute and useMatchRoute test coverage for React, Solid, and Vue, covering typed params, fuzzy matching, and mismatch cases.
Chores
- Added a patch changeset documenting the matching fix.

coderabbitai · 2026-07-11T00:00:03Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Last reviewed commit: 06a3de5
Latest commit, not reviewed: 7404bb0

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

matchRoute now parses route parameters before matching and returns typed values. Route-tree extraction preserves parsed state across branches, core tests cover matching modes, and React, Solid, and Vue tests verify typed hook results.

Changes: Typed route matching

Layer / File(s)	Summary
Track parsed route parameters `packages/router-core/src/new-process-route-tree.ts`	Route-tree matching records route metadata, separates raw and parsed parameters, and carries parsed values through parser validation and branch exploration.
Parse parameters during route matching `packages/router-core/src/router.ts`, `.changeset/plenty-jokes-listen.md`	`matchRoute` resolves destination branches, validates parsed parameters and search values, handles fuzzy remainders, returns typed params, and updates processed-tree types.
Validate core matching behavior `packages/router-core/tests/match-route.test.ts`, `packages/router-core/tests/{path,optional-path-params*}.test.ts`	Tests cover typed parsing, parser failures, parent-child params, fuzzy and case-sensitive matching, search, base paths, trailing slashes, and migration to `findRouteMatch`.
Verify typed adapter results `packages/{react-router,solid-router,vue-router}/tests/Matches.test.tsx`	Framework adapter tests verify that `useMatchRoute` returns numeric parameters from custom parsers.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant useMatchRoute
  participant RouterCoreMatchRoute
  participant RouteTreeMatcher
  participant RouteParamParser
  useMatchRoute->>RouterCoreMatchRoute: Match route with typed params
  RouterCoreMatchRoute->>RouteTreeMatcher: Resolve destination branch
  RouteTreeMatcher->>RouteParamParser: Parse extracted parameters
  RouteParamParser-->>RouteTreeMatcher: Return parsed params or rejection
  RouteTreeMatcher-->>RouterCoreMatchRoute: Return parsed route match
  RouterCoreMatchRoute-->>useMatchRoute: Return typed match or false

Possibly related PRs

TanStack/router#5722: Updates matchRoute and route-tree matching around parsed parameter extraction and validation.

Suggested labels: package: router-core

Suggested reviewers: schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: matchRoute now supports parsed params.
Linked Issues check	✅ Passed	The changes address `#2450` by making MatchRoute/matchRoute honor custom parse/stringify for numeric params and adding regression tests.
Out of Scope Changes check	✅ Passed	The deletions and API updates appear tied to the matchRoute refactor and related test coverage, with no unrelated changes evident.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch match-route-parsed-params

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-07-11T00:00:12Z

View your CI Pipeline Execution ↗ for commit 7404bb0

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 47s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-24 18:52:13 UTC

github-actions · 2026-07-11T00:01:05Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 22 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/router-core`	1.171.39 → 1.171.40	Changeset
`@tanstack/react-router`	1.170.46 → 1.170.47	Dependent
`@tanstack/react-start`	1.169.4 → 1.169.5	Dependent
`@tanstack/react-start-client`	1.168.44 → 1.168.45	Dependent
`@tanstack/react-start-rsc`	0.1.65 → 0.1.66	Dependent
`@tanstack/react-start-server`	1.167.52 → 1.167.53	Dependent
`@tanstack/router-cli`	1.167.46 → 1.167.47	Dependent
`@tanstack/router-generator`	1.167.46 → 1.167.47	Dependent
`@tanstack/router-plugin`	1.168.48 → 1.168.49	Dependent
`@tanstack/router-vite-plugin`	1.167.48 → 1.167.49	Dependent
`@tanstack/solid-router`	1.170.43 → 1.170.44	Dependent
`@tanstack/solid-start`	1.169.4 → 1.169.5	Dependent
`@tanstack/solid-start-client`	1.168.42 → 1.168.43	Dependent
`@tanstack/solid-start-server`	1.167.50 → 1.167.51	Dependent
`@tanstack/start-client-core`	1.170.39 → 1.170.40	Dependent
`@tanstack/start-plugin-core`	1.171.55 → 1.171.56	Dependent
`@tanstack/start-server-core`	1.169.45 → 1.169.46	Dependent
`@tanstack/start-static-server-functions`	1.167.44 → 1.167.45	Dependent
`@tanstack/start-storage-context`	1.167.41 → 1.167.42	Dependent
`@tanstack/vue-router`	1.170.42 → 1.170.43	Dependent
`@tanstack/vue-start`	1.169.4 → 1.169.5	Dependent
`@tanstack/vue-start-client`	1.167.45 → 1.167.46	Dependent
`@tanstack/vue-start-server`	1.167.50 → 1.167.51	Dependent

…ck/router into match-route-parsed-params

pkg-pr-new · 2026-07-11T00:10:23Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7776

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7776

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7776

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7776

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7776

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7776

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7776

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7776

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7776

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7776

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7776

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7776

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7776

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7776

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7776

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7776

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7776

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7776

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7776

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7776

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7776

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7776

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7776

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7776

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7776

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7776

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7776

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7776

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7776

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7776

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7776

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7776

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7776

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7776

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7776

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7776

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7776

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7776

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7776

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7776

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7776

commit: 7404bb0

github-actions · 2026-07-11T00:15:05Z

Bundle Size Benchmarks

Commit: 814783c0428b
Measured at: 2026-10-24T18:47:12.058Z
Baseline source: history:6b9fe6d29552
Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Initial (gzip)	Raw	Brotli	Trend
`react-router.minimal`	84.5 KiB +441 B	84.3 KiB +445 B	262.6 KiB +1.2 KiB	73.8 KiB +479 B	▁▁▁▁▁▁▁▁▁▁▁█
`react-router.full`	88.0 KiB +440 B	87.9 KiB +442 B	274.5 KiB +1.2 KiB	76.8 KiB +402 B	▁▁▁▁▁▁▁▁▁▁▁█
`solid-router.minimal`	33.7 KiB +408 B	33.6 KiB +408 B	96.4 KiB +1.2 KiB	30.5 KiB +385 B	▁▁▁▁▁▁▁▁▁▁▁█
`solid-router.full`	38.7 KiB +424 B	38.5 KiB +424 B	111.2 KiB +1.2 KiB	35.0 KiB +490 B	▁▁▁▁▁▁▁▁▁▁▁█
`vue-router.minimal`	49.8 KiB +435 B	49.7 KiB +437 B	137.6 KiB +1.2 KiB	45.2 KiB +401 B	▁▁▁▁▁▁▁▁▁▁▁█
`vue-router.full`	55.4 KiB +454 B	55.3 KiB +452 B	155.8 KiB +1.2 KiB	50.1 KiB +401 B	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.minimal`	97.2 KiB +443 B	97.1 KiB +440 B	303.5 KiB +1.2 KiB	84.5 KiB +363 B	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.query-integration`	104.6 KiB +444 B	104.5 KiB +447 B	330.1 KiB +1.2 KiB	90.8 KiB +361 B	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.deferred-hydration`	97.9 KiB +468 B	97.1 KiB +466 B	304.9 KiB +1.2 KiB	85.1 KiB +430 B	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.full`	100.3 KiB +447 B	100.2 KiB +450 B	312.8 KiB +1.2 KiB	87.1 KiB +566 B	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.rsbuild.minimal`	100.8 KiB +456 B	100.6 KiB +456 B	314.5 KiB +1.2 KiB	87.1 KiB +462 B	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.rsbuild.minimal-iife`	101.2 KiB +456 B	101.0 KiB +456 B	315.4 KiB +1.2 KiB	87.4 KiB +443 B	▁▁▁▁▁▁▁▁▁▁▁█
`react-start.rsbuild.full`	104.0 KiB +446 B	103.8 KiB +446 B	324.2 KiB +1.2 KiB	89.7 KiB +362 B	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.minimal`	46.6 KiB +424 B	46.4 KiB +422 B	136.2 KiB +1.2 KiB	41.5 KiB +419 B	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.deferred-hydration`	49.6 KiB +421 B	46.5 KiB +421 B	143.5 KiB +1.2 KiB	44.4 KiB +470 B	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.full`	51.6 KiB +426 B	51.5 KiB +425 B	151.2 KiB +1.2 KiB	45.8 KiB +337 B	▁▁▁▁▁▁▁▁▁▁▁█
`vue-start.minimal`	65.8 KiB +439 B	65.7 KiB +443 B	186.9 KiB +1.2 KiB	58.8 KiB +317 B	▁▁▁▁▁▁▁▁▁▁▁█
`vue-start.full`	69.6 KiB +457 B	69.4 KiB +455 B	198.7 KiB +1.2 KiB	62.0 KiB +378 B	▁▁▁▁▁▁▁▁▁▁▁█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

codspeed · 2026-07-11T00:17:59Z

Merging this PR will degrade performance by 0.29%

2 warnings

⚠️ 38 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 6 regressed benchmarks
✅ 182 untouched benchmarks
⏩ 3 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Memory	`mem client preload-churn (react)`	78.3 KB	84.9 KB	-7.77%
❌	Memory	`mem server error-paths redirect (react)`	12.4 KB	13.4 KB	-7.46%
❌	CPU Simulation	`ssr assets inline-css cdn (vue)`	360.6 ms	382.8 ms	-5.79%
❌	CPU Simulation	`ssr assets inline-css cdn (solid)`	181.2 ms	190.6 ms	-4.9%
❌	Memory	`mem client preload-churn (solid)`	75.5 KB	79.4 KB	-4.85%
❌	Memory	`mem client navigation-churn (solid)`	107.4 KB	111.6 KB	-3.79%
⚡	Memory	`mem client navigation-churn (react)`	83.6 KB	76 KB	+10.07%
⚡	Memory	`mem client interrupted-navigations (react)`	94.7 KB	87.4 KB	+8.41%
⚡	Memory	`mem server aborted-requests (react)`	298.5 KB	285.6 KB	+4.51%
⚡	Memory	`mem server error-paths redirect (vue)`	13.1 KB	12.6 KB	+3.61%
⚡	Memory	`mem client unique-location-churn (vue)`	82.9 KB	80 KB	+3.59%
⚡	Memory	`mem client interrupted-navigations (vue)`	95.7 KB	92.9 KB	+3.04%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing match-route-parsed-params (7404bb0) with main (6b9fe6d)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sheraff

I think it makes sense to fix this. But also router.matchRoute is broken more generally because it does not take the route tree into account. It could return true for the specific route you're asking for, but when actually compared against the entire tree, another route would match because it had higher matching priority.

LadyBluenotes · 2026-07-11T15:51:06Z

I think it makes sense to fix this. But also router.matchRoute is broken more generally because it does not take the route tree into account. It could return true for the specific route you're asking for, but when actually compared against the entire tree, another route would match because it had higher matching priority.

Added a regression for osts/edit versus posts/$postId. So when full-tree matching identifies /posts/edit as the winner, matchRoute({ to: '/posts/$postId' }) now returns false. The existing fallback remains for route branches that cannot be resolved through parser-aware tree matching :))

…th matching

LadyBluenotes · 2026-07-11T20:11:15Z

@Sheraff made the changes we talked about in discord

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

packages/router-core/src/new-process-route-tree.ts (2)
812-849: 🚀 Performance & Scalability | 🔵 Trivial | ⚖️ Poor tradeoff

findMatch always redoes full extraction from scratch, discarding the incremental extract state already computed during getNodeMatch.

When includeRouteParams is set, the constructed leaf object omits extract (only node, skipped, rawParams are carried over), forcing extractParams to restart from partIndex/nodeIndex/pathIndex/segmentCount = 0 even though the winning frame may already have partially-resumed extract state from earlier validateParseParams calls along the branch. This is correct but redundant for branches that use .parse(), doing O(n) extraction twice. Worth a look if this path is hot, though likely low priority given branch depth is typically small.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/router-core/src/new-process-route-tree.ts` around lines 812 - 849,
Reuse the incremental extract state from getNodeMatch in findMatch instead of
restarting extractParams from zero. Preserve the winning leaf frame’s extract
data when constructing or passing the leaf, and update extractParams to continue
from that state while retaining existing rawParams and matchData behavior.
688-696: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

RouteMatchData is defined but not reused for the identical inline shapes.

The new RouteMatchData type (line 858-862) exactly matches the matchData element shape that's independently inlined three more times: RouteMatch<T>.matchData (692-696), findMatch's return type (820-824), and extractParams's return tuple (885-889). Consolidating onto the shared alias avoids the four copies drifting apart if the shape changes later.
♻️ Proposed refactor
 type RouteMatch<T extends Extract<RouteLike, { fullPath: string }>> = {
   route: T
   rawParams: Record<string, string>
   branch: ReadonlyArray<T>
-  matchData: ReadonlyArray<{
-    rawParams?: Record<string, string>
-    pathnameEnd: number
-    caseSensitive: boolean
-  }>
+  matchData: ReadonlyArray<RouteMatchData>
 }
 ): {
   route: T
   rawParams: Record<string, string>
-  matchData?: ReadonlyArray<{
-    rawParams?: Record<string, string>
-    pathnameEnd: number
-    caseSensitive: boolean
-  }>
+  matchData?: ReadonlyArray<RouteMatchData>
 } | null {
   extractedParams: Record<string, string>,
-  matchData?: Array<{
-    rawParams?: Record<string, string>
-    pathnameEnd: number
-    caseSensitive: boolean
-  }>,
+  matchData?: Array<RouteMatchData>,
 ] {
(Note: TypeScript type aliases aren't order-sensitive, so RouteMatchData can be referenced ahead of its declaration without issue.)
Also applies to: 813-825, 858-863, 885-889
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/router-core/src/new-process-route-tree.ts` around lines 688 - 696,
Reuse the shared RouteMatchData alias for every matchData element type instead
of repeating its inline shape. Update RouteMatch<T>.matchData, findMatch’s
return type, and extractParams’ return tuple to reference RouteMatchData, while
keeping the alias definition and existing type structure unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/router-core/src/new-process-route-tree.ts`:
- Line 951: Update the one-line conditionals in the route-tree logic: wrap the
body of the `if (part)` statement around `pathIndex += part.length` and the body
of the `if (result === false)` statement around `return null` in curly braces,
preserving their existing behavior.

---

Nitpick comments:
In `@packages/router-core/src/new-process-route-tree.ts`:
- Around line 812-849: Reuse the incremental extract state from getNodeMatch in
findMatch instead of restarting extractParams from zero. Preserve the winning
leaf frame’s extract data when constructing or passing the leaf, and update
extractParams to continue from that state while retaining existing rawParams and
matchData behavior.
- Around line 688-696: Reuse the shared RouteMatchData alias for every matchData
element type instead of repeating its inline shape. Update
RouteMatch<T>.matchData, findMatch’s return type, and extractParams’ return
tuple to reference RouteMatchData, while keeping the alias definition and
existing type structure unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af4b87d9-0cd5-46e6-9821-c5369b926b71

📥 Commits

Reviewing files that changed from the base of the PR and between 24a76d9 and 06a3de5.

📒 Files selected for processing (7)

packages/router-core/src/new-process-route-tree.ts
packages/router-core/src/router.ts
packages/router-core/tests/match-by-path.test.ts
packages/router-core/tests/match-route.test.ts
packages/router-core/tests/optional-path-params-clean.test.ts
packages/router-core/tests/optional-path-params.test.ts
packages/router-core/tests/path.test.ts

💤 Files with no reviewable changes (1)

packages/router-core/tests/match-by-path.test.ts

🚧 Files skipped from review as they are similar to previous changes (1)

packages/router-core/src/router.ts

This reverts commit cbe3506.

…rCore

Reuse the path matcher for case-sensitive and fuzzy checks, including repeated parameter names and root paths. Consolidate parameter decoding and only collect per-route data when needed.

Sheraff · 2026-09-10T06:28:17Z

Can you remind me why we still need the findSingleMatch method if it now respects the tree? Why not use the same findRouteMatch as we use for regular route matching?

Sheraff · 2026-09-10T17:08:03Z

does this collide with https://github.com/TanStack/router/pull/8327/changes?

LadyBluenotes · 2026-09-10T17:11:23Z

does this collide with https://github.com/TanStack/router/pull/8327/changes?

there's conflicts in files, if that's what youre referring to. I can stack this on manuel's?

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Re-applies parsed-param matchRoute support on top of main's rewritten route matcher (#8327): findRouteMatch now records per-route raw params and path boundaries, matchRoute reuses the active matches, and params.parse gates see parsed ancestor params.

nx-cloud

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

View detailed reasoning in Nx Cloud ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

changeset-bot · 2026-10-24T18:24:54Z

🦋 Changeset detected

Latest commit: 7404bb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
@tanstack/router-core	Patch
@tanstack/react-router	Patch
@tanstack/react-start-client	Patch
@tanstack/react-start-rsc	Patch
@tanstack/react-start-server	Patch
@tanstack/router-generator	Patch
@tanstack/router-plugin	Patch
@tanstack/solid-router	Patch
@tanstack/solid-start-client	Patch
@tanstack/solid-start-server	Patch
@tanstack/start-client-core	Patch
@tanstack/start-plugin-core	Patch
@tanstack/start-server-core	Patch
@tanstack/start-storage-context	Patch
@tanstack/vue-router	Patch
@tanstack/vue-start-client	Patch
@tanstack/vue-start-server	Patch
@tanstack/react-start	Patch
@tanstack/router-cli	Patch
@tanstack/router-vite-plugin	Patch
@tanstack/solid-start	Patch
@tanstack/start-static-server-functions	Patch
@tanstack/vue-start	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LadyBluenotes added 3 commits July 10, 2026 12:20

reproduce matchRoute typed param failure

35af8c8

reproduce matchRoute typed param failures

2471c1c

enhance parameter parsing and matching with custom functions

22af4b8

github-actions Bot added package: react-router package: router-core package: solid-router package: vue-router labels Jul 10, 2026

LadyBluenotes mentioned this pull request Jul 11, 2026

tests: reproducer for #2450 #2460

Closed

LadyBluenotes requested a review from Sheraff July 11, 2026 00:00

LadyBluenotes requested a review from schiller-manuel July 11, 2026 00:00

autofix-ci Bot and others added 3 commits July 11, 2026 00:01

ci: apply automated fixes

24d14d8

changeset

94c8373

Merge branch 'match-route-parsed-params' of https://github.com/TanSta…

f396cca

…ck/router into match-route-parsed-params

This comment was marked as outdated.

Sign in to view

Sheraff reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/router-core/src/router.ts Resolved

updates as per comments

24a76d9

This comment was marked as outdated.

Sign in to view

LadyBluenotes added 2 commits July 11, 2026 13:07

refactor: replace findSingleMatch with findRouteMatch for improved pa…

06a3de5

…th matching

update changeset

df01347

LadyBluenotes requested a review from Sheraff July 11, 2026 20:11

coderabbitai Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/router-core/src/new-process-route-tree.ts Resolved

This comment was marked as outdated.

Sign in to view

LadyBluenotes added 3 commits July 11, 2026 16:12

return parsed params from matchRoute

cbe3506

add brackets to make coderabbit happy

23c1da9

Revert "return parsed params from matchRoute"

8363a29

This reverts commit cbe3506.

This comment was marked as outdated.

Sign in to view

LadyBluenotes and others added 11 commits July 11, 2026 18:09

reuse parsed route matches in matchRoute

7dd0bab

improve bundle sizes

c074b62

remove experiment

4191e13

refactor: streamline parameter extraction and matching logic in Route…

7ecd488

…rCore

ci: apply automated fixes

c1f3318

add tests for reusing active matches and decoding fuzzy parameters

618b07f

ci: apply automated fixes

9276fdd

refactor: remove unused import for removeTrailingSlash in router.ts

6556dae

fix(router-core): preserve exact and fuzzy match boundaries

16605dc

fix(router-core): simplify parsed-parameter matching

d7cb5ee

Reuse the path matcher for case-sensitive and fuzzy checks, including repeated parameter names and root paths. Consolidate parameter decoding and only collect per-route data when needed.

Merge branch 'main' into match-route-parsed-params

97b30a7

LadyBluenotes added 2 commits September 10, 2026 09:41

refactor(router-core): share route matching and reduce allocations

ded5852

perf(router-core): simplify route matching traversal

03adac4

This comment was marked as outdated.

Sign in to view

LadyBluenotes and others added 3 commits September 11, 2026 18:01

perf(router-core): trim the current pathname once in matchRoute

3603c27

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

ci: Version Packages (#8486) [Self-Healing CI Rerun]

38db3cf

nx-cloud Bot reviewed Sep 25, 2026

View reviewed changes

Merge branch 'main' into match-route-parsed-params

7404bb0

LadyBluenotes mentioned this pull request Oct 24, 2026

Tracking: open Router and Start PRs by problem area #8810

Open

23 tasks

Conversation

LadyBluenotes commented Jul 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Benchmarks

Uh oh!

codspeed Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 0.29%

Performance Changes

Footnotes

Uh oh!

This comment was marked as outdated.

Uh oh!

Sheraff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LadyBluenotes commented Jul 11, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

LadyBluenotes commented Jul 11, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Sheraff commented Sep 10, 2026

Uh oh!

Sheraff commented Sep 10, 2026

Uh oh!

LadyBluenotes commented Sep 10, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud Bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a flaky task in your failed CI:

Uh oh!

changeset-bot Bot commented Oct 24, 2026

🦋 Changeset detected

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LadyBluenotes commented Jul 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 11, 2026 •

edited

Loading

nx-cloud Bot commented Jul 11, 2026 •

edited

Loading

github-actions Bot commented Jul 11, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 11, 2026 •

edited

Loading

github-actions Bot commented Jul 11, 2026 •

edited

Loading

codspeed Bot commented Jul 11, 2026 •

edited

Loading