Repository navigation
Conversation
Test Results 12 files 12 suites 15m 19s ⏱️ Results for commit e7d432d. ♻️ This comment has been updated with latest results. |
When the `Times` argument of `Verify` was not a literal `Times.X` expression, the fixer left the Moq call on the migrated mock without a hint, and `VerifyGet`/`VerifySet`/`VerifyAdd`/`VerifyRemove` silently fell back to `AtLeastOnce()`, which turns e.g. a `Times.Never()` variable into a weaker assertion. All five now keep the original call and add `// TODO(MockolateM001): translate the Times argument '<expr>' manually`. - A `string` second argument is Moq's fail message, not a `Times` argument, and still migrates to `AtLeastOnce()` (Moq's default); for `Verify` this was previously left untouched. - The NSubstitute fixer has no such approximation: `Received(n)` maps to `Exactly(n)` for any expression.
vbreuss
force-pushed
the
fix/todo-for-untranslated-constructs
branch
from
October 18, 2026 23:46
8c6fc47 to
e7d432d
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
Timesargument ofVerifywas not a literalTimes.Xexpression, the fixer left the Moq call on the migrated mock without a hint, andVerifyGet/VerifySet/VerifyAdd/VerifyRemovesilently fell back toAtLeastOnce(), which turns e.g. aTimes.Never()variable into a weaker assertion. All five now keep the original call and add// TODO(MockolateM001): translate the Times argument '<expr>' manually.stringsecond argument is Moq's fail message, not aTimesargument, and still migrates toAtLeastOnce()(Moq's default); forVerifythis was previously left untouched.Received(n)maps toExactly(n)for any expression.