Skip to content

✅ Make sorting test more robust - #4

Merged
TkDodo merged 1 commit into
TkDodo:feature/react-18from
prateek3255:fix/devtools-test
Nov 29, 2021
Merged

TkDodo merged 1 commit into
TkDodo:feature/react-18from
prateek3255:fix/devtools-test

Conversation

@prateek3255

Copy link
Copy Markdown

No description provided.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (feature/react-18@c7d9f7b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             feature/react-18       #4   +/-   ##
===================================================
  Coverage                    ?   96.18%           
===================================================
  Files                       ?       47           
  Lines                       ?     2200           
  Branches                    ?      629           
===================================================
  Hits                        ?     2116           
  Misses                      ?       81           
  Partials                    ?        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d9f7b...180c87a. Read the comment docs.

@prateek3255

Copy link
Copy Markdown
Author

@TkDodo I slightly increased the gap between the time taken by different queries to resolve, also using the queryClient's
isFetching method to determine if there are any pending queries instead of using a hardcoded value. Also ran the test locally multiple times with different node versions and it seems to be working fine now.

Comment thread src/devtools/tests/devtools.test.tsx
@TkDodo
TkDodo merged commit 73f1389 into TkDodo:feature/react-18 Nov 29, 2021
@prateek3255
prateek3255 deleted the fix/devtools-test branch November 29, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants