Repository navigation
Create new Purge command. - #238
RealYusufIsmail wants to merge 6 commits into
Conversation
Why are you requesting my review on a Draft PR? Is the PR ready now or not? It still has TODO and other stuff. |
I never. |
You did.
|
Well I don't know how I did it. I don't recall requesting a review |
| private static void getBetween0(long firstMessageId, long lastMessageId, MessageChannel mc, | ||
| List<String> acc, ReentrantLock lock, Consumer<List<String>> cb) { |
There was a problem hiding this comment.
| private static void getBetween0(long firstMessageId, long lastMessageId, MessageChannel mc, | |
| List<String> acc, ReentrantLock lock, Consumer<List<String>> cb) { | |
| private static void getBetween0(long firstMessageId, long lastMessageId, MessageChannel mc, | |
| List<String> acc, ReentrantLock lock, Consumer<List<String>> cb) { |
mc, Minecraft?
acc, accuracy?
cb? CubeCraft?
This is about Minecraft?
I don't like the abbreviations myself and I'd prefer longer, more clear names.
I currently can't comment on the behaviour since I'm not sure what "cb" and "acc" their purpose is.
| return; | ||
| } | ||
|
|
||
| final Member bot = Objects.requireNonNull(event.getGuild()).getSelfMember(); |
There was a problem hiding this comment.
Some places you use final, some you don't (on local variables)
I'd recommend keeping consistency, and either use it everywhere or nowhere.
|
|
|
This PR is in a rather bad state and there was pretty much no activity for 2-3 weeks. On top, the requirements of what such a purge command should do exactly havent been discussed through fully yet. I am closing this for now. |
This is a draft of the purge command.
As discussed in the purge command issue #17 This command will allow you to delete from one message to another using there message ids.
/purge id(first message) id(last message)