Skip to content

Thread created by NamedThreadFactory should be a daemon #1390

Closed

Description

@z1c0

In src/main/java/org/java_websocket/util/NamedThreadFactory.java, when a new Thread gets created, it should be marked as a background thread.

thread.setDaemon(true);

I'm using this library in a context where I have no control over shutdown (I get no callback or notification) and this thread is preventing proper shutdown.

Activity

  1. PhilipRoman commented on Feb 2, 2024

    @PhilipRoman
    Collaborator

    Looks like we already have open PR #1201 for this. I will review it when I have time and most likely merge.

  2. z1c0 commented on Feb 2, 2024

    @z1c0
    Author

    Great news! Thanks

  3. added this to the Release 1.5.6 milestone on Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions