You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Thread created by NamedThreadFactory should be a daemon #1390
In src/main/java/org/java_websocket/util/NamedThreadFactory.java, when a new Thread gets created, it should be marked as a background thread.
thread.setDaemon(true);
I'm using this library in a context where I have no control over shutdown (I get no callback or notification) and this thread is preventing proper shutdown.
Activity
PhilipRoman commentedon Feb 2, 2024
Looks like we already have open PR #1201 for this. I will review it when I have time and most likely merge.
z1c0 commentedon Feb 2, 2024
Great news! Thanks