Improve code quality for 1.4.0 #749

Activity

1. marci4

   added this to the Release 1.3.10This milestone has been deleted milestone on Aug 6, 2018
2. PhilipRoman commented on Aug 6, 2018

   

   PhilipRoman

   on Aug 6, 2018

   Collaborator

   More actions

   Glad to see I'm not the only one staring at SonarQube reports 😮! On a more serious note, I think the first thing to do should be splitting up the large methods into smaller ones. This is guaranteed not to break anything and it could even help to achieve better performance. Reading some of the code currently is quite hard and improving code quality may help more people contribute in the future.

   Again, thanks for bringing this up!

   👍React with 👍1Reacted by Marcel Prestel
3. marci4 commented on Aug 6, 2018

   

   marci4

   on Aug 6, 2018

   CollaboratorAuthor

   More actions

   Yeah we really have to do this!
   Helps us and everyone checking all the methods.
   Especially the WebSocketServer is a beauty in itself ;)
4. marci4

   added

   Refactor

   on Aug 8, 2018
5. marci4

   modified the milestones: Release 1.3.10This milestone has been deleted, Release 1.4.0 on Sep 6, 2018
6. marci4

   changed the title [-]Improve code quality[/-] [+]Improve code quality for 1.4.0[/+] on Feb 17, 2019
7. marci4 commented on Feb 17, 2019

   

   marci4

   on Feb 17, 2019

   CollaboratorAuthor

   More actions

   We have a code close for 1.4.0.

   Maybe opening another issue for 1.4.1.

   Closing this issue as solved!
8. marci4

   closed this as completedon Feb 17, 2019