Skip to content

onFragment() deprecated? #751

Closed
Closed

Description

@egueli

Hi all,

the application I'm maintaining overrides WebSocketServer.onFragment(Websocket, Framedata). The IDE marks that method as deprecated, because of this annotation:

  • why is onFragment deprecated?
  • what should one do instead?

Thank you for any information!

Activity

  1. egueli commented on Aug 11, 2018

    @egueli
    Author

    I see this is related to #570.

    If I read correctly the changes, WebsocketListener.onWebsocketMessageFragment() will never be called anymore and neither will WebsocketServer.onFragment()?

  2. marci4 commented on Aug 11, 2018

    @marci4
    Collaborator

    Hello @egueli,

    These changes where made since most of the users expected to receive all messages using OnMessage regardless of how the message was sent.
    You're application should work without any problems by simply using OnMessage (string/bytebuffer)

    Best regards,
    marci4

  3. egueli commented on Aug 12, 2018

    @egueli
    Author

    Thank you. In my case, there wasn't much logic in onFragment so I could remove it altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions