Repository navigation
fix: bump Go to 1.26.11 for GO-2026-6859 - #1218
Conversation
govulncheck now reports GO-2026-6859 (HTTP/1 server crash due to a MaxBytesReader header race in net/http) against Go 1.26.10, which fails Security & Code Health on every open PR. It is fixed in 1.26.11. The go directive moves to 1.26.11, and the documented source-build minimum in README.md, README_ZH.md and docs/INSTALL.md moves with it.
Zero automated PR reviewVerdict: No blockers found Blockers
Validation
ScopeHead: This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality. |
|
No actionable comments were generated in the recent review. WalkthroughThe Go toolchain directive and documented Go version requirements change from 1.26.10 to 1.26.11. ChangesGo Version Requirement
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk:
|
jatmn
left a comment
There was a problem hiding this comment.
Merge readiness
Rebase onto current main (ecd6e115) before merge. The branch merge-base is one commit behind live main (#1213). A trial merge shows no conflicts on the four changed files; rebasing is still the project’s stated fresh-base expectation in AGENTS.md.
Prebuilt GitHub Release and npm platform binaries compiled at Go 1.26.10 will continue to carry GO-2026-6859 until the next release artifact cut. That is expected for a go.mod-only bump and is not blocked by this diff, but maintainers should plan a release after merge if they want install-by-binary users on the patched stdlib immediately.
Optional follow-up (not required for this PR): bin/zero.js still says Go 1.26+ in the missing-binary source-recovery path—the same coarse wording #1168 left unchanged. After this bump, 1.26.10 no longer satisfies go.mod while it still fits “1.26+”. Aligning that string with 1.26.11+ would reduce confusion on the npm fallback path; it is outside the #1168 file scope this PR intentionally mirrors.
🟢 Thanks for the contribution. I do not see any actionable issues from my review.
What changed
Bump the
godirective to 1.26.11. CI and release builds read the toolchain fromgo.mod, so that is the only version they use. The stated source-build minimum inREADME.md,README_ZH.mdanddocs/INSTALL.mdmoves with it, as in #1168.CHANGELOG.mdis left to release-please.Why
govulncheckreads the live database, and GO-2026-6859 was added to it aftermainlast went green on 2026-11-10.Security & Code Healthnow fails on every open PR (#835 and #1211 today) with no code change behind it, andmainwill fail the same way on its next run:It is fixed in 1.26.11. Same shape as #1168.
Linked issue
None. Maintainer fix for a required check that is red on every PR, opened through the internal development process.
Verification
On Windows, with the pinned
govulncheck@v1.3.0run forGOOS=linuxand forGOOS=windows, the way the two CI steps run it:Also on this branch:
go vet ./...for windows, linux and darwin, the releasebuildandsmoke,go test ./..., andgit diff --check.Summary by CodeRabbit