Skip to content

[bug] v2 dashboard: the old /apps/<app>/setup link freezes the tab #2183

Description

@EugenEistrach

Executor version

2.0.0-beta.8 (built from the executor@2.0.0-beta.8 tag with a small server-side patch; the web app is unmodified). The setup route and AccountSelectionPage are unchanged on v2 at ed608b7.

How do you run Executor?

Self-host (Docker)

Operating system

Linux (Chrome)

What happened

Opening /org/<org>/apps/<app>/setup, with or without ?profile=, never leaves the page. The main area stays empty, the tab stops responding, and eventually Chrome shows "Aw, Snap!" (SIGILL). It happens for every app we tried; every other dashboard page works.

AccountSelectionPage (apps/hosted/web/src/implementation/pages/account-selection.tsx) renders <Navigate params={{…}} search={{…}} replace /> with new objects on every render. TanStack Router's Navigate (1.170.41) calls navigate(props) in a layout effect whenever props changes. The navigation re-renders the setup route before it commits, which creates new props and starts the next navigation, so it never completes. Pausing the frozen tab shows Navigate's effect → router.navigate → commitLocation → load, over and over.

What you expected

One redirect to /org/<org>/apps/<app>?view=accounts, which works when opened directly.

Steps to reproduce

  1. Sign in to the dashboard.
  2. Open https://<host>/org/<org>/apps/<any app id>/setup.
  3. The tab stops responding within a few seconds.

Redirecting in the route's beforeLoad (throw redirect(...)) instead of rendering <Navigate> would likely avoid it.

Diagnostics / logs

Nothing on the server; the loop runs in the browser.

  • I searched the open issues for a duplicate.
  • I removed all keys, tokens, and credentials from this report.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions