This repository was archived by the owner on Oct 30, 2026. It is now read-only.
Repository navigation
Separate container lifecycle from deployment assertions - #3830
Open
adamtheturtle wants to merge 1 commit into
Open
adamtheturtle wants to merge 1 commit into
adamtheturtle wants to merge 1 commit into
Conversation
adamtheturtle
had a problem deploying
to
vuforia
October 29, 2026 18:57 — with 
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3741.
Move image building, network/port setup, readiness probes and container cleanup into
vws_mock_server_tests.deployment. Keep the six deployment assertions and their test IDs intest_docker.py, importing the same module-scoped fixture and a publicMockDeploymentresult type. This makes the lifecycle reusable by server-owned contract adapters.Validation: all six existing Docker deployment tests passed. AST comparison preserves setup/teardown behavior, retry bounds and test assertions apart from the result type's name. Full pre-commit/pre-push checks, CI partition validation and Pylint passed.