Replace FHT assembly with AVX intrinsics - #112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the GNU inline assembly and Windows MASM FHT kernels with shared AVX intrinsics used by the AVX2 and AVX-512 rotation backends. Preserve butterfly ordering, four rotation passes, normalization, and saved rotation state while removing the assembler build dependency.
Saved-index formats and production dependencies are unchanged. The previously installed internal
rabitqlib/utils/fht_avx.hppheader is removed; downstream code directly including it must migrate.Testing
RABITQ_ENABLE_NATIVE_OPTIMIZATION=OFF, including explicit AVX2 and AVX-512 rotation checks.git diff --checkpassed.Local FHT microbenchmarks were kept outside the repository. This PR makes no end-to-end query performance claim.