Honor explicit DefaultValueHandling for bools - #1847
Merged
Merged
Conversation
bool members were unconditionally given DefaultValueHandling.Include at the property level, which overrides the global setting. So an explicit AddExtraSettings(_ => _.DefaultValueHandling = Ignore) could never drop false. Track whether an extra setting explicitly assigns DefaultValueHandling (using null as a sentinel, since the property is nullable) and skip the bool special case when it has. Default behavior is unchanged. Fixes #1660
This was referenced Aug 26, 2026
This was referenced Sep 24, 2026
samtrion
added a commit
to dailydevops/pulse
that referenced
this pull request
Sep 28, 2026
Verify 32 omits boolean members with default value false (VerifyTests/Verify#1847). Only IsSuppressed, IsWarningAsError, IsInMetadata and IsInSource entries with value false were removed; no content change.
68 of 69 tasks
samtrion
added a commit
to dailydevops/pulse
that referenced
this pull request
Sep 28, 2026
* chore(deps): update dependency verify.tunit to v33 * build(deps): declare Verify OpenSource sponsorship exemption Verify v33 enforces the Open Source Maintenance Fee at build time and fails with SC021 without a declaration. Declare the OpenSource exemption (valid until 2027-09) in every test project that references Verify.TUnit. * test(sourcegeneration): update Verify snapshots for v33 serialization Verify 32 omits boolean members with default value false (VerifyTests/Verify#1847). Only IsSuppressed, IsWarningAsError, IsInMetadata and IsInSource entries with value false were removed; no content change. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Martin Stühmer <martin@stuehmer.net>
This was referenced Sep 28, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bool members were unconditionally given DefaultValueHandling.Include at the property level, which overrides the global setting. So an explicit AddExtraSettings(_ => _.DefaultValueHandling = Ignore) could never drop false.
Track whether an extra setting explicitly assigns DefaultValueHandling (using null as a sentinel, since the property is nullable) and skip the bool special case when it has. Default behavior is unchanged.
Fixes #1660