Repository navigation
Remove doc-comment from WIT.md - #281
Merged
Merged
Conversation
Resolves #273
lann
approved these changes
Dec 4, 2023
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Dec 5, 2023
This updates `wit-parser` to account for WebAssembly/component-model#281. Doc comments are now considered to be all forms of comments and are collected in the `Docs` structure. The structure already stripped all leading `/` characters so it works for either `///` or `//`. Additionally docs are now printed with `//` instead of `///`.
Collaborator
|
I've opened bytecodealliance/wasm-tools#1313 for the tooling side of this |
Member
Author
|
Great! Given overall agreement here and in #273, I'll go ahead and merge now. |
alexcrichton
added a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Dec 6, 2023
* Parse and print `//`-style comments as docs This updates `wit-parser` to account for WebAssembly/component-model#281. Doc comments are now considered to be all forms of comments and are collected in the `Docs` structure. The structure already stripped all leading `/` characters so it works for either `///` or `//`. Additionally docs are now printed with `//` instead of `///`. * Update test expectations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #273, this PR just removes the
doc-commentproduction from WIT.md. (In case you were wondering, I didn't forget to remove uses ofdoc-comment; it just wasn't referenced anywhere that I could see.)