Repository navigation
CABI: tighten subtask.cancel behavior - #723
Merged
Merged
Conversation
alexcrichton
approved these changes
Sep 16, 2026
alexcrichton
left a comment
Collaborator
There was a problem hiding this comment.
This seems reasonable to me, although this is an aspect of Wasmtime which is "probably whatever just happened to or was easiest to implement" so I wouldn't want to over-rotate on this too too much. This is a spec corner that seems possible to tweak in the future if necessary, however, and I'm always a fan of more tests!
dicej
approved these changes
Sep 16, 2026
dicej
left a comment
Collaborator
There was a problem hiding this comment.
LGTM; thanks for the new tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent PR #716 attempted to give the host more flexibility for which-and-how-many of the subtask's threads are to be resumed during
subtask.cancelby replacing thecandidatesset with a plainthread.yield. Butthread.yieldactually isn't quite right and while testing Wasmtime I see that's both more-permissive and less-permissive in different cases. This new PR aims to fix this in a way that matches Wasmtime's behavior (which seems pretty reasonable from what I can tell) as tested by a set of new WAST tests that all currently pass. But @dicej and @alexcrichton lemme know if the new rules described in the PR sound right or if I'm missing something.