Repository navigation
[js-api] Reject a mutable global import before allocating - #2263
Open
chicoxyzzy wants to merge 1 commit into
Open
chicoxyzzy wants to merge 1 commit into
chicoxyzzy wants to merge 1 commit into
Conversation
Fixes WebAssembly#2253. A non-Global value for a var import was passed to global_alloc as a const global. module_instantiate then rejected the mutability mismatch and left that global in the store. Throw a LinkError before allocating. A const import of a var Global is the same mismatch. Throw before appending that global. A fresh global is allocated with the import's mut, which is const once the var case has been rejected.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2253.
read the importsignoredmutand always calledglobal_allocwithconst valtypewhen the value was not aGlobal. Avarimport then failed inmodule_instantiate, and theconstglobal stayed in the store.Throw a
LinkErrorin that case before allocating. Also throw when aconstimport is avarGlobal, which is the same mismatch and used to be reported only bymodule_instantiate. Allocate a fresh global with the import'smut. After thevarrejection, thatmutisconst.A
varimport of aconstGlobalis unchanged: nothing is allocated, andmodule_instantiatestill checks the types.The new test covers a
constimport of a mutableGlobalfori32,i64,f32, andf64.