Build/Test Tools: Disable login autofocus during 6.3 E2E tests - #13942
lancewillett wants to merge 1 commit into
Conversation
Delayed login autofocus can clear a password after automated typing. Required-field validation then prevents the navigation the helper awaits. Install the existing autofocus filter as a temporary E2E must-use plugin, following Gutenberg's test fixture. Remove the runner's own copy after completion or interruption, preserving existing plugins. See #58592.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation is focused, preserves existing plugins, and handles normal and interrupted cleanup correctly.
Review effort: Balanced
Findings: None
What changed in this PR
Disables delayed login autofocus during WordPress 6.3 E2E runs and reliably cleans up the temporary fixture.
Changes:
- Adds a temporary must-use plugin that disables login autofocus.
- Updates the runner to preserve arguments, forward signals, and clean up the fixture.
- Documents fixture behavior and external-installation usage.
| File | Description |
|---|---|
tests/e2e/run-tests.js |
Manages the fixture and test subprocess lifecycle. |
tests/e2e/mu-plugins/README.md |
Documents installation and cleanup behavior. |
tests/e2e/mu-plugins/disable-login-autofocus.php |
Disables login autofocus through the existing filter. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
WordPress 6.3’s delayed login autofocus can clear a typed password. Required-field validation then blocks submission, so the legacy E2E helper times out waiting for navigation.
Use the existing
enable_login_autofocusfilter in a temporary must-use plugin, following Gutenberg #6129. The runner respectsLOCAL_DIR, preserves existing plugins, and removes its own fixture after completion or interruption.Trac ticket: #58592, as a 6.3 follow-up to the timeout investigation closed after 6.4 moved to Playwright.
Validation:
All 24 executed hosted checks passed. The full E2E suite passed 16/16 tests with SCRIPT_DEBUG enabled and 16/16 disabled. Assertions, timeouts, and retries remain unchanged.
AI assistance: Codex assisted with investigation, implementation, review, and local validation.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.