Skip to content

PHP 8.2 | GH Actions: start running the unit tests against PHP 8.2 - #3119

Closed
jrfnl wants to merge 1 commit into
WordPress:trunkfrom
jrfnl:feature/ghactions-add-php-8.2
Closed

jrfnl wants to merge 1 commit into
WordPress:trunkfrom
jrfnl:feature/ghactions-add-php-8.2

Conversation

@jrfnl

@jrfnl jrfnl commented Aug 23, 2022

Copy link
Copy Markdown
Member

Notes:

  • The composer install for PHP 8.1 was still using --ignore-platform-reqs, while that hasn't been needed anymore for quite a while, so I'm just re-using the condition for PHP 8.2 now.
  • I've also made the --ignore-platform... option used for the install more specific.
    Composer 2.0 added a --ignore-platform-req=... option to selectively ignore platform requirements.
    Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the + sign.
  • As discussed for PHP 8.1, builds against PHP 8.2 will still be allowed to fail (and will fail, not just due to new PHP 8.2 issues, but also due to unsolved PHP 8.1 issues). Allowing those builds to fail prevents merges in the Gutenberg project becoming blocked.
  • As for the Xdebug related tests: those will not be run on PHP 8.2 yet as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2.

Refs:

Trac ticket: https://core.trac.wordpress.org/ticket/56009


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Notes:
* The `composer install` for PHP 8.1 was still using `--ignore-platform-reqs`, while that hasn't been needed anymore for quite a while, so I'm just re-using the condition for PHP 8.2 now.
* I've also made the `--ignore-platform...` option used for the install more specific.
    Composer 2.0 added a `--ignore-platform-req=...` option to selectively ignore platform requirements.
    Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the `+` sign.
* As discussed for PHP 8.1, builds against PHP 8.2 will still be allowed to fail (and will fail, not just due to new PHP 8.2 issues, but also due to unsolved PHP 8.1 issues). Allowing those builds to fail prevents merges in the Gutenberg project becoming blocked.
* As for the Xdebug related tests: those will not be run on PHP 8.2 yet as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2.

Refs:
* WordPress/wpdev-docker-images#87
* https://github.com/composer/composer/releases/tag/2.0.0
* https://github.com/composer/composer/releases/tag/2.2.0
* https://xdebug.org/announcements/2022-07-20
* https://xdebug.org/announcements/2022-07-25
@jrfnl
jrfnl requested a review from desrosj August 23, 2022 09:10
@jrfnl

jrfnl commented Aug 23, 2022

Copy link
Copy Markdown
Member Author

Previous similar ticket for PHP 8.1: https://core.trac.wordpress.org/ticket/53891

@SergeyBiryukov

Copy link
Copy Markdown
Member

Thanks for the PR! Merged in r53922.

@jrfnl

jrfnl commented Aug 23, 2022

Copy link
Copy Markdown
Member Author

Thank you @SergeyBiryukov !

@jrfnl
jrfnl deleted the feature/ghactions-add-php-8.2 branch August 23, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants