The about check command does not make enough checks

[pombredanne]

The about check command could do more checks: it does not check if the license expressions syntax is correct or if the licenses keys are valid. It also does not check that some important field are present such as license_expression

[chinyeungli]

@pombredanne in terms of important field, license_expression is not a required field and, therefore, it should not be checked for the existence of the license_expression field. OR should we make this field required?

[chinyeungli]

If we need to verify the correctness of the license keys, we need user to provide valid api key to access the to DJC.
Perhaps the solution is to add an option for user to enter the api key if user want to check for the license keys and expression.

[chinyeungli]

@pombredanne Let me know if this fixed the need

[pombredanne]

We should IMHO always check the validity of license_expressions and optionally we should check that the license keys are known license keys. Doing a remote check by default is not the best way IMHO.
I am not we want to have a --check-licenses option for now... we should spend some time to design the right set of checks we want

[pombredanne]

I am pushing this the V4 milestone. We need to discuss a bit the design of checks