Adding support for zipped abouts in genattrib - #216
Merged
Conversation
Contributor
|
One minor suggestion is to add the "Finished" word once the generation is completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits add support to run genattrib from a directory of zipped ABOUT files for #210 .
I also added minimal tests for genattrib from a directory and from a zip file.
The way this works is rather simple: if the
input_partargument ends with zip and is a zip file, then it is first extracted to a temp directory and that directory is then used as ininput_pathfor generationOne area that has not been tested is how these things work when there are additional CSV to filter the generated attribution.