Support spaces in filename #310 - #359
Merged
Merged
Conversation
Member
|
@chinyeungli There are failing tests that need to be fixed to merge this |
The spec does not state if spaces are supported. The previous code will throw the following critical error if space is detected in file name: ``` CRITICAL: Invalid characters ' ' in file name at: ``` This commit add ' ' as a valid character. Signed-off-by: Chin Yeung Li <tli@nexb.com>
pombredanne
force-pushed
the
310_support_spaces_in_path
branch
from
November 18, 2018 10:20
8a29ceb to
a757fb0
Compare
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Member
|
All green with the latest test updates. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec does not state if spaces are supported. The previous code will
throw the following critical error if space is detected in file name:
This commit add ' ' as a valid character.
Signed-off-by: Chin Yeung Li tli@nexb.com