417, 418: modified transform to work with json from scancode and renamed configuration key for transform - #419
Merged
chinyeungli merged 8 commits intoMar 13, 2020
Conversation
srthkdb
commented
Mar 11, 2020
Contributor
- Processes only the data inside "files"
- Automatically renames "path" to "about_resource"
- Written tests
Contributor
|
@srthkdb Can you try to fix the failing tests? |
Signed-off-by: Srthkdb <srthkdb@iitk.ac.in>
Signed-off-by: Srthkdb <srthkdb@iitk.ac.in>
srthkdb
force-pushed
the
417_json_transform
branch
from
March 11, 2020 16:15
b5459a1 to
db03ed1
Compare
Signed-off-by: Srthkdb <srthkdb@iitk.ac.in>
srthkdb
force-pushed
the
417_json_transform
branch
from
March 11, 2020 17:04
fe9d54a to
ed891cf
Compare
Contributor
Author
|
@chinyeungli Fixed! |
…d_renamings, required_fields and field_filters respectively Signed-off-by: Srthkdb <srthkdb@iitk.ac.in>
Signed-off-by: Srthkdb <srthkdb@iitk.ac.in>
srthkdb
force-pushed
the
417_json_transform
branch
from
March 11, 2020 17:39
df270fb to
32cce1b
Compare
Signed-off-by: Srthkdb <srthkdb@iitk.ac.in>
srthkdb
force-pushed
the
417_json_transform
branch
from
March 11, 2020 18:23
fde993e to
b7e70a4
Compare
Signed-off-by: Srthkdb <srthkdb@iitk.ac.in>
srthkdb
force-pushed
the
417_json_transform
branch
from
March 11, 2020 18:28
fa27766 to
5007d12
Compare
Contributor
Author
|
I have also renamed column_renamings, required_columns, and column_filters to field_renamings, required_fields, and field_filters respectively. |
chinyeungli
reviewed
Mar 11, 2020
Signed-off-by: Srthkdb <srthkdb@iitk.ac.in>
srthkdb
force-pushed
the
417_json_transform
branch
from
March 12, 2020 06:37
06387d1 to
68b82cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.