add missing html tag "</p>" / clean-up template to get smaller and cleaner output - #470
Merged
Merged
Conversation
- replace spaces for indentation with tabs and move indentation of dyn-html commands into the commands itself to. This reduces the size of the output html and makes generated output much cleaner. (needed for embedded devices with small storage) Signed-off-by: Stephan Enderlein <stephan@freifunk-dresden.de>
…_html.template Signed-off-by: Stephan Enderlein <stephan@freifunk-dresden.de>
Signed-off-by: Stephan Enderlein <stephan@freifunk-dresden.de>
Contributor
|
@ddmesh thanks for the pull request. However, we'll still prefer spaces over tabs. Can you restore the spaces? Thanks again. |
Contributor
Author
|
no problem, because the indentation is now within the dyn-html commands {%...%}, those spaces will not be rendered into the output html. -> done. |
Signed-off-by: Stephan Enderlein <stephan@freifunk-dresden.de>
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
</p><p>This component is licensed under {{ about_object.license_expression.value }}</p>This reduces the size of the output html and makes generated output much cleaner. (needed for embedded devices with
small storage)
Signed-off-by: Stephan Enderlein stephan@freifunk-dresden.de